Upgrade to operator sdk latest v1.22.1 #831
Conversation
bdunne
force-pushed
the
upgrade_to_operator-sdk_latest
branch
4 times, most recently
from
db3f523 to
d7c9285
Compare
Fryguy
changed the title
bdunne
force-pushed
the
upgrade_to_operator-sdk_latest
branch
3 times, most recently
from
77ad279 to
920af8c
Compare
bdunne
force-pushed
the
upgrade_to_operator-sdk_latest
branch
from
920af8c to
18ae5f5
Compare
We already watch for secret changes in our namespace. The only advantage that this had was in the case of a change to the httpd auth config secret we would only reconcile httpd. I don't think this added complexity is worth the time difference. Also, rewriting all of this code to fit the latest operator-sdk is very complicated.
There were only a few callers left and this method was also complicated to upgrade, switch these callers to CreateOrUpdate for consistency
These will be generated in the new version
Remove the deploy and teardown scripts
- Add notes about fetching additional dependencies - Update to new make commands - Fully qualify base docker image
make manifests apparently can't generate RBAC properly - It overwrites the names - It wants a namespace specified, which we don't want - It can't handle the blank group
Trying to grant "*" raises an error since the role attached to our service account doesn't have "*" permissions.
Building with and without GOARCH on x86_64 produces results with the same md5sum.
No breaking changes in v1.19 or v1.20
No changes necessary for the golang operator https://sdk.operatorframework.io/docs/upgrading-sdk-version/v1.22.1/
bdunne
force-pushed
the
upgrade_to_operator-sdk_latest
branch
from
5f40779 to
cc87bb6
Compare
|
Checked commits bdunne/manageiq-pods@0c9ab80~...a6d37bc with ruby 2.6.9, rubocop 1.19.1, haml-lint 0.35.0, and yamllint **
|
|
Actually just noticed the golang tests aren't running anything: https://github.com/ManageIQ/manageiq-pods/runs/7435811883?check_suite_focus=true#step:7:21 |
Yep, we don't have any go tests yet, but we should probably run the suite anyway since it verifies that other things are working and it will be ready to go once we add some tests. |
I think we're ready to go and can fix anything else in followup PRs. |
|
Oh I thought these were tests, but it just looks like the test setup. |
|
Nice work @bdunne !!! 🎉 |
|
Great stuff @bdunne ! |
I tried to make the commits make sense because there were a few things that were not so easy to upgrade, and I made those commits before the upgrade changes.
TODO:
Fixes #624