Clean more files after dnf installing #844
Conversation
| @@ -7,6 +7,7 @@ COPY container-assets/ /vddk/ | |||
|
|
|||
| RUN /vddk/extract-vmware-vddk | |||
|
|
|||
| ################################################################################ | |||
There was a problem hiding this comment.
This makes it easier to see various multi-stage builds - I can remove from this PR if you want, but I figured it was fine.
| @@ -35,6 +37,7 @@ RUN chmod -R g+w /etc/pki/ca-trust && \ | |||
|
|
|||
| COPY rpms/* /tmp/rpms/ | |||
| COPY container-assets/create_local_yum_repo.sh / | |||
| COPY container-assets/clean_dnf_rpm /usr/local/bin/ | |||
There was a problem hiding this comment.
I'm open to renaming this script.
| dnf clean all && \ | ||
| rm -rf /var/cache/dnf | ||
|
|
||
| RUN rm -rf /tmp/rpms /create_local_yum_repo.sh /etc/yum.repos.d/local_rpm.repo |
There was a problem hiding this comment.
I wasn't sure why this was done here. Removing these doesn't change anything with respect to the file size, and one can get at them from one of the parent images.
There was a problem hiding this comment.
I think we used to install something here, but it was moved up in the layers.
| rm -rf /var/cache/dnf | ||
| clean_dnf_rpm | ||
|
|
||
| # Build the RPM manifest |
There was a problem hiding this comment.
I thought we were keeping this as close as possible to the end in case any other steps were added with dnf commands
There was a problem hiding this comment.
I was actually considering moving the dumb-init and ADD calls up the file. If you're ok with that for this PR I can do that, and then this is at the "end" of the file again.
There was a problem hiding this comment.
Even so, the only calls afterwards are an ADD, and the curl of dumb-init, so this is technically at the "end" of any dnf commands
There was a problem hiding this comment.
I'm fine with moving them up, they're only used at runtime, not build time so the order doesn't matter.
There was a problem hiding this comment.
Not for this PR, but dumb-init is up to v1.2.5 now, so we should probably update. Also, should we rely on pulling it from Github at every build or do you think we should keep a copy somewhere else (package it in an RPM)?
There was a problem hiding this comment.
Oh yes I saw that - will have a follow-up PR
There was a problem hiding this comment.
@bdunne Updated. I moved up both commands
| chgrp root /var/log/httpd && \ | ||
| chmod g+rwx /var/log/httpd | ||
|
|
||
| # Build the RPM manifest |
There was a problem hiding this comment.
Any reason to merge the other RUN steps but not this one?
There was a problem hiding this comment.
It doesn't save any space to merge the manifest one, though admittedly it would drop the need to duplicate the clean_dnf_rpm call. I'd like to leave it for now.
| @@ -0,0 +1,11 @@ | |||
| #!/bin/bash | |||
There was a problem hiding this comment.
Not for this PR, but I wonder if we should put this script in one of our RPMs and run it on the appliance to reduce image size there too
There was a problem hiding this comment.
Oh that's an interesting idea - agreed that we can do that in a follow up
This change reduces the UI worker image size from 2.063GB to 2.018GB (44MB, 2.1%) - Add the removal of dnf logs, dnf history, and rpm __db lock files. This eliminates roughly 2-6MB per invocation. - Move the cleaning of dnf and rpm assets into a script, which makes it easier to use across layers and images. - Remove redundant rebuild of the rpm manifests, since ther are unnecessary unless rpm changes are made. - Collapse the modifications of the httpd package into the same layer as when it's installed. Part of ManageIQ#736
|
Checked commit Fryguy@8d98b60 with ruby 2.6.9, rubocop 1.19.1, haml-lint 0.35.0, and yamllint |
|
I forgot to mention this also has significant time savings as well. Locally, the rpm manifest generation steps can take ~100s (1m40s) x 5 images = ~500s (8m20s). After this PR, there are only 2 calls, so that's 200s (3m20s) for a savings of ~5min per build Updated the OP with this information. |
This change reduces the UI worker image size from 2.063GB to 2.018GB
(44MB, 2.1%)
This eliminates roughly 2-6MB per invocation.
easier to use across layers and images.
unnecessary unless rpm changes are made.
when it's installed.
Part of #736
EDIT: I forgot to mention this also has significant time savings as well. Locally, the rpm manifest generation steps can take ~100s (1m40s) x 5 images = ~500s (8m20s). After this PR, there are only 2 calls, so that's 200s (3m20s) for a savings of ~5min per build