Remove obsolete SPICE console option #272
Conversation
| # | ||
| # @return [String] The content of the cofiguration file. | ||
| # | ||
| def generate_remote_viewer_file |
There was a problem hiding this comment.
As far as I can tell this was never called, https://github.com/search?q=org%3AManageIQ%20generate_remote_viewer_file&type=code
There was a problem hiding this comment.
Should this be killed also, then?
There was a problem hiding this comment.
I also found this semi-related method in ovirt (and rhv):
There was a problem hiding this comment.
Should this be killed also, then?
Yes, done
I also found this semi-related method in ovirt (and rhv):
Ovirt/RHV still use spice so that is still used, spice was only removed from kubevirt
There was a problem hiding this comment.
Weird - the comment on the queue method says ui-classic calls it - but I checked the entire diff history of ui-classic and it's not there.
There was a problem hiding this comment.
Yeah I checked the same, my guess is that it was started but never finished. This method was added in the initial commit of the entire provider so there wasn't a PR to see where the work was going.
This was removed by kubevirt and replaced with VNC support
agrare
force-pushed
the
remove_obsolete_spice_proxy_console
branch
from
5e72a49 to
e899c30
Compare
This was removed by kubevirt in kubevirt/kubevirt#618 and replaced with VNC support
Related: #268 adding VNC support