Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Gem.loaded_specs looking for wrong key name #863

Merged
merged 1 commit into from
Oct 30, 2023
Merged

Fix Gem.loaded_specs looking for wrong key name #863

merged 1 commit into from
Oct 30, 2023

Conversation

agrare
Copy link
Member

@agrare agrare commented Oct 30, 2023

Gem.loaded_specs has string keys which was causing this check to
always return false

(byebug) Gem.loaded_specs.key?(:qpid_proton)
false
(byebug) Gem.loaded_specs.key?("qpid_proton")
true

@agrare
Fix Gem.loaded_specs looking for wrong key name
5a2c9ec 
`Gem.loaded_specs` has string keys which was causing this check to
always return false
@agrare agrare requested a review from Fryguy as a code owner October 30, 2023 16:44
@agrare agrare mentioned this pull request Oct 30, 2023
Merged
@agrare
Copy link
Member Author

agrare commented Oct 30, 2023

Found while testing ManageIQ/manageiq-providers-nuage#299

@jrafanie
Copy link
Member

Wow, nice find @agrare. I wonder when this changed.

jrafanie
jrafanie approved these changes Oct 30, 2023
View reviewed changes
Copy link
Member

@jrafanie jrafanie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jrafanie jrafanie merged commit ff466c2 into ManageIQ:master Oct 30, 2023
3 checks passed
@jrafanie jrafanie self-assigned this Oct 30, 2023
@agrare agrare deleted the fix_gem_loaded_specs_qpid_proton_key branch October 30, 2023 17:46
@Fryguy
Copy link
Member

Fryguy commented Oct 31, 2023

Backported to quinteros in commit e210b4f.

commit e210b4f3e77482e09f2ae88f04c87498a957ddc0
Author: Joe Rafaniello <jrafanie@users.noreply.github.com>
Date:   Mon Oct 30 13:44:05 2023 -0400

    Merge pull request #863 from agrare/fix_gem_loaded_specs_qpid_proton_key
    
    Fix Gem.loaded_specs looking for wrong key name
    
    (cherry picked from commit ff466c29c9855f0854ea8a1087033232149ebbe5)

Fryguy pushed a commit that referenced this pull request Oct 31, 2023
@jrafanie @Fryguy
Merge pull request #863 from agrare/fix_gem_loaded_specs_qpid_proton_key
e210b4f 
Fix Gem.loaded_specs looking for wrong key name

(cherry picked from commit ff466c2)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrafanie jrafanie jrafanie approved these changes

@Fryguy Fryguy Awaiting requested review from Fryguy Fryguy is a code owner

Assignees

@jrafanie jrafanie

Labels
bug quinteros/backported test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@agrare @jrafanie @Fryguy