Drop ruby requirement from gemspec #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fryguy
force-pushed
the
drop_ruby_requirement
branch
from
6178bb2 to
0b255ca
Compare
The Ruby requirement will ultimately come from whatever version of rubocop we use, so there's no need for us to pin it here. It turns out that rubocop 1.56.3 require Ruby 2.7, but having it here makes it appear like a decision of manageiq-style as opposed to the restriction coming from rubocop itself.
Fryguy
force-pushed
the
drop_ruby_requirement
branch
from
0b255ca to
6e6dc39
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Ruby requirement will ultimately come from whatever version of
rubocop we use, so there's no need for us to pin it here. It turns out
that rubocop 1.56.3 require Ruby 2.7, but having it here makes it appear
like a decision of manageiq-style as opposed to the restriction coming
from rubocop itself.
@kbrock Please review.