[WIP] bump rubocop to 1.68.0 #56
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This no longer depends upon rexml. Rexml has been showing a number of CVEs recently, so it would be nice to get away from it. At least as a transitive dependency. (we still depend upon it for some of our code)
|
This is completely based on what's available from code climate. There is a rake task here that will pull the latest and update all the things. EDIT: Sorry, I was slightly wrong - there's code in here to detect it, but it's not in a rake task. That being said, the list is basically this https://github.com/codeclimate/codeclimate-rubocop/branches/all?query=channel, which as you can see the latest channel is 1.56.3. |
|
We could possibly move to channel/beta - not sure what that would entail from other configuration things. See also codeclimate/codeclimate-rubocop#374 |
|
Holding off and will upgrade once Code Climate updates |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main goal is to drop rexml dependency
WIP: want to fix some warnings before pushing this forward
@miq-bot cross-repo-test /all