Skip to content

Commit

Permalink
Merge pull request #22768 from Fryguy/drop_ruby_27
Browse files Browse the repository at this point in the history
Drop Ruby 2.7 support
  • Loading branch information
jrafanie authored Oct 31, 2023
2 parents e1341c7 + 8b5ddb1 commit eab273e
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 7 deletions.
2 changes: 0 additions & 2 deletions .github/workflows/ci.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@ jobs:
strategy:
matrix:
ruby-version:
- '2.7'
- '3.0'
test-suite:
- vmdb
Expand Down Expand Up @@ -43,7 +42,6 @@ jobs:
uses: ruby/setup-ruby@v1
with:
ruby-version: "${{ matrix.ruby-version }}"
rubygems: "${{ matrix.ruby-version == '2.7' && 'latest' || 'default' }}"
bundler-cache: true
timeout-minutes: 30
- name: Prepare tests
Expand Down
2 changes: 1 addition & 1 deletion Gemfile
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
raise "Ruby versions < 2.7.0 are unsupported!" if RUBY_VERSION < "2.7.0"
raise "Ruby versions < 3.0.0 are unsupported!" if RUBY_VERSION < "3.0.0"
raise "Ruby versions >= 3.1.0 are unsupported!" if RUBY_VERSION >= "3.1.0"

source 'https://rubygems.org'
Expand Down
5 changes: 1 addition & 4 deletions spec/models/custom_attribute_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -12,9 +12,6 @@
end

it "returns the value type of Integer custom attributes" do
# TODO: Ruby 2.4 unifies fixnum and bignum into integer, we shouldn't be
# returnings ruby types like this.
expected = RUBY_VERSION >= "2.4.0" ? :integer : :fixnum
expect(int_custom_attribute.value_type).to eq(expected)
expect(int_custom_attribute.value_type).to eq(:integer)
end
end

0 comments on commit eab273e

Please sign in to comment.