Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check in changes - DEVR-3489-fix-bugs-for-generating-title #207

Merged
merged 3 commits into from
Nov 18, 2024

Conversation

lm3388
Copy link
Collaborator

@lm3388 lm3388 commented Oct 29, 2024

Updates made to add an argument in each of tlf_* functions for allowing the user to claim which analysis name is using; corresponding changes were also made testthat programs and vignettes program which called the tbl_* function. With this change, the argument referring an analysis is a requirement parameter of all tlf_* function.

@lm3388 lm3388 requested a review from wangben718 October 29, 2024 19:44
@wangben718
Copy link
Collaborator

Thanks for your PR, @lm3388 . Could you check every example is updated? Also, remember to run devtools::document() when you update.

@lm3388
Copy link
Collaborator Author

lm3388 commented Nov 4, 2024

Thanks for your suggestion, @wangben718. I have run devtools::document() when having updates and afterwards. And 2 more files impacted have also been updated: test-independent-testing-empty_table.R and metalite-ae.Rmd. All latest updates have been submitted to GitHub for your review.

@wangben718 wangben718 merged commit aab6a5e into main Nov 18, 2024
@nanxstats nanxstats deleted the DEVR-3489-fix-bugs-for-generating-title branch November 19, 2024 00:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants