Fix access control in menu and routes #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daniel-cintra
requested changes
Oct 2, 2024
There was a problem hiding this comment.
Hi! Thanks for your time in this Pull Request :)
For better consistence across the permissions system, we can adopt the following pattern:
->can('Acl: Permission - List')
Starting the permission name always with capital letters and ending with the CRUD method when possible.
So:
can('Acl: permission - List') becomes can('Acl: Permission - List')
can('Acl: Role - Manage Permissions') becomes can('Acl: Role: Permission - Edit')
Thanks for your collaboration!
Fixed permission issues affecting certain areas of the package and added logic to show or hide a button based on the authenticated user's permissions.
|
Hi, I’ve made the requested changes to the pull request, including the adjustments you mentioned. Please review and let me know if further modifications are needed. |
mehedijaman
approved these changes
Oct 4, 2024
|
Thanks @stivenm0 and @mehedijaman |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.