Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PSY -> PSSE Exporter #32

Closed
wants to merge 2 commits into from
Closed

PSY -> PSSE Exporter #32

wants to merge 2 commits into from

Conversation

HaleyRoss
Copy link
Collaborator

Adding raw code for a PowerSystems -> PSS/e exporter module, plus the foundation of the testing for the new exporter. To be cleaned, reformatted, and integrated into the rest of the code base still.

@HaleyRoss HaleyRoss requested a review from scdhulipala March 19, 2024 17:51
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

JuliaFormatter

src/psse_exporter/psse_exporter.jl|123|
src/psse_exporter/psse_exporter.jl|127|
src/psse_exporter/psse_exporter.jl|132|
src/psse_exporter/psse_exporter.jl|134|
src/psse_exporter/psse_exporter.jl|140|
src/psse_exporter/psse_exporter.jl|148|
src/psse_exporter/psse_exporter.jl|154|
src/psse_exporter/psse_exporter.jl|158|
src/psse_exporter/psse_exporter.jl|169|
src/psse_exporter/psse_exporter.jl|179|
src/psse_exporter/psse_exporter.jl|182|
src/psse_exporter/psse_exporter.jl|188|
src/psse_exporter/psse_exporter.jl|192|
src/psse_exporter/psse_exporter.jl|194|
src/psse_exporter/psse_exporter.jl|206|
src/psse_exporter/psse_exporter.jl|209|
src/psse_exporter/psse_exporter.jl|213|
src/psse_exporter/psse_exporter.jl|217|
src/psse_exporter/psse_exporter.jl|221|
src/psse_exporter/psse_exporter.jl|228|
src/psse_exporter/psse_exporter.jl|250|
src/psse_exporter/psse_exporter.jl|258|
src/psse_exporter/psse_exporter.jl|264|
src/psse_exporter/psse_exporter.jl|267|
src/psse_exporter/psse_exporter.jl|279|
src/psse_exporter/psse_exporter.jl|288|
src/psse_exporter/psse_exporter.jl|300|
src/psse_exporter/psse_exporter.jl|304|
src/psse_exporter/psse_exporter.jl|319|
src/psse_exporter/psse_exporter.jl|328|
src/psse_exporter/psse_exporter.jl|338|
src/psse_exporter/psse_exporter.jl|340|
src/psse_exporter/psse_exporter.jl|345|
src/psse_exporter/psse_exporter.jl|365|
src/psse_exporter/psse_exporter.jl|368|
src/psse_exporter/psse_exporter.jl|372|
src/psse_exporter/psse_exporter.jl|381|
src/psse_exporter/psse_exporter.jl|402|
src/psse_exporter/psse_exporter.jl|404|
src/psse_exporter/psse_exporter.jl|408|
src/psse_exporter/psse_exporter.jl|426|
src/psse_exporter/psse_exporter.jl|435|
src/psse_exporter/psse_exporter.jl|469|
src/psse_exporter/psse_exporter.jl|478|
src/psse_exporter/psse_exporter.jl|482|
src/psse_exporter/psse_exporter.jl|494|
src/psse_exporter/psse_exporter.jl|505|
src/psse_exporter/psse_exporter.jl|514|
src/psse_exporter/psse_exporter.jl|518|
src/psse_exporter/psse_exporter.jl|542|
src/psse_exporter/psse_exporter.jl|548|
src/psse_exporter/psse_exporter.jl|552|
src/psse_exporter/psse_exporter.jl|555|
src/psse_exporter/psse_exporter.jl|557|
src/psse_exporter/psse_exporter.jl|573|
src/psse_exporter/psse_exporter.jl|588|
src/psse_exporter/psse_exporter.jl|605|
src/psse_exporter/psse_exporter.jl|610|
src/psse_exporter/psse_exporter.jl|622|
src/psse_exporter/psse_exporter.jl|629|
src/psse_exporter/psse_exporter.jl|634|
src/psse_exporter/support_tools.jl|6|
src/psse_exporter/support_tools.jl|20|
src/psse_exporter/support_tools.jl|36|
src/psse_exporter/support_tools.jl|52|
src/psse_exporter/support_tools.jl|66|
src/psse_exporter/support_tools.jl|75|
src/psse_exporter/support_tools.jl|85|
src/psse_exporter/support_tools.jl|95|
src/psse_exporter/support_tools.jl|107|
src/psse_exporter/support_tools.jl|119|
src/psse_exporter/support_tools.jl|136|
src/psse_exporter/support_tools.jl|151|
src/psse_exporter/support_tools.jl|154|
src/psse_exporter/support_tools.jl|156|
src/psse_exporter/support_tools.jl|160|
src/psse_exporter/support_tools.jl|176|
src/psse_exporter/support_tools.jl|179|
src/psse_exporter/test_powerflow.jl|32|
src/psse_exporter/test_powerflow.jl|49|
src/psse_exporter/test_powerflow.jl|53|
src/psse_exporter/test_powerflow.jl|55|
src/psse_exporter/test_powerflow.jl|74|
src/psse_exporter/test_powerflow.jl|100|
src/psse_exporter/test_powerflow.jl|128|

src/psse_exporter/compare_psse_results.jl Outdated Show resolved Hide resolved
src/psse_exporter/compare_psse_results.jl Outdated Show resolved Hide resolved
src/psse_exporter/compare_psse_results.jl Outdated Show resolved Hide resolved
src/psse_exporter/compare_psse_results.jl Outdated Show resolved Hide resolved
src/psse_exporter/compare_psse_results.jl Outdated Show resolved Hide resolved
src/psse_exporter/psse_exporter.jl Outdated Show resolved Hide resolved
src/psse_exporter/psse_exporter.jl Outdated Show resolved Hide resolved
src/psse_exporter/psse_exporter.jl Outdated Show resolved Hide resolved
src/psse_exporter/psse_exporter.jl Outdated Show resolved Hide resolved
src/psse_exporter/psse_exporter.jl Outdated Show resolved Hide resolved
Copy link

codecov bot commented Mar 19, 2024

Codecov Report

Attention: Patch coverage is 0% with 487 lines in your changes are missing coverage. Please review.

Project coverage is 58.11%. Comparing base (456a1bb) to head (bcd4158).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main      #32       +/-   ##
===========================================
- Coverage   88.35%   58.11%   -30.24%     
===========================================
  Files           9       13        +4     
  Lines         936     1423      +487     
===========================================
  Hits          827      827               
- Misses        109      596      +487     
Flag Coverage Δ
unittests 58.11% <0.00%> (-30.24%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/psse_exporter/test_powerflow.jl 0.00% <0.00%> (ø)
src/psse_exporter/compare_psse_results.jl 0.00% <0.00%> (ø)
src/psse_exporter/support_tools.jl 0.00% <0.00%> (ø)
src/psse_exporter/psse_exporter.jl 0.00% <0.00%> (ø)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this here?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This hasn't been cleaned up yet. I will make this a PR after we've cleaned it up and is ready for your review.

@GabrielKS
Copy link
Contributor

Closing as superseded by the "stable" branch https://github.com/NREL-Sienna/PowerFlows.jl/tree/hrgks/psse_exporter_psy4, the "development" branch https://github.com/NREL-Sienna/PowerFlows.jl/tree/gks/hr/formalize_psse_exporter, and the draft PR #42.

@GabrielKS GabrielKS closed this Jul 15, 2024
@GabrielKS GabrielKS deleted the hr/psse_exporter branch November 5, 2024 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants