Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add xpress patch #1051

Merged
merged 11 commits into from
Feb 9, 2024
Merged

add xpress patch #1051

merged 11 commits into from
Feb 9, 2024

Conversation

jd-lara
Copy link
Member

@jd-lara jd-lara commented Feb 8, 2024

See jump-dev/Xpress.jl#212 for reference to this. It seems to be the only solution that is under our control.

@jd-lara jd-lara requested a review from daniel-thom February 8, 2024 16:34
Copy link
Contributor

github-actions bot commented Feb 8, 2024

Performance Results

Version Precompile Time
Main 3.278164735
This Branch 3.279457328
Version Build Time
Main-Build Time Precompile 52.199772599
Main-Build Time Postcompile 2.608605466
This Branch-Build Time Precompile 52.040759779
This Branch-Build Time Postcompile 2.871208105

Copy link

codecov bot commented Feb 8, 2024

Codecov Report

Attention: 23 lines in your changes are missing coverage. Please review.

Comparison is base (d993157) 80.57% compared to head (0a15ae6) 80.48%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1051      +/-   ##
==========================================
- Coverage   80.57%   80.48%   -0.10%     
==========================================
  Files         116      116              
  Lines       12418    12439      +21     
==========================================
+ Hits        10006    10011       +5     
- Misses       2412     2428      +16     
Flag Coverage Δ
unittests 80.48% <23.33%> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/core/definitions.jl 68.75% <ø> (ø)
src/core/optimizer_stats.jl 73.33% <ø> (ø)
src/operation/decision_model.jl 92.50% <ø> (ø)
src/utils/jump_utils.jl 66.27% <ø> (ø)
src/operation/operation_model_interface.jl 76.53% <0.00%> (-1.20%) ⬇️
src/core/optimization_container.jl 77.91% <26.92%> (-1.18%) ⬇️

@jd-lara
Copy link
Member Author

jd-lara commented Feb 9, 2024

@odow this is the best I came up with to fix the problem with Xpress

@jd-lara jd-lara self-assigned this Feb 9, 2024
src/core/definitions.jl Outdated Show resolved Hide resolved
jd-lara and others added 3 commits February 8, 2024 17:56
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@odow
Copy link
Contributor

odow commented Feb 9, 2024

@jd-lara jd-lara merged commit d807a50 into main Feb 9, 2024
8 of 9 checks passed
@jd-lara jd-lara deleted the jd/xpress_patch branch February 23, 2024 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants