-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wrap PythonPlugin:SearchPaths #214
base: develop
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is used in python_plugin.osm. Did you delete it by mistake?
# create the python plugin search paths object (this test should fail without it) | ||
python_plugin_search_paths = model.getPythonPluginSearchPaths | ||
python_plugin_search_paths.setAddCurrentWorkingDirectorytoSearchPath(true) | ||
python_plugin_search_paths.setAddInputFileDirectorytoSearchPath(true) | ||
python_plugin_search_paths.setAddepinEnvironmentVariabletoSearchPath(true) | ||
python_plugin_search_paths.addSearchPath(File.dirname(__FILE__)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you confirm this fails without this object please?
@@ -0,0 +1 @@ | |||
print('hello world') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
print('hello world') | |
# This file is used by python_plugin_search_paths | |
print('hello world') |
…s based on the stem and prepare for the new OSM test
python_plugin_search_paths.setAddCurrentWorkingDirectorytoSearchPath(True) | ||
python_plugin_search_paths.setAddInputFileDirectorytoSearchPath(True) | ||
python_plugin_search_paths.setAddepinEnvironmentVariabletoSearchPath(True) | ||
python_plugin_search_paths.addSearchPath(str(Path(__file__).parent)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added a python version. Really the fact that this takes only a string bothers me.
when 'python_plugin.osm', 'python_plugin_search_paths' | ||
# We need to manually copy the supporting schedule into | ||
# the testruns folder for the simulation to be able to find it | ||
program_file_name = "#{File.basename(filename, File.extname(filename))}_program.py" | ||
plugin_ori_path = File.join(File.dirname(__FILE__), | ||
'model/simulationtests/python_plugin_program.py') | ||
'model/simulationtests', program_file_name) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When running the OSM version, copy the program.py file, which is computed as "#{stem}_program.py
python_plugin.osm -> python_plugin_program.py
python_plugin_search_paths.osm -> python_plugin_search_paths_program.py
stem = File.basename(__FILE__, File.extname(__FILE__)) | ||
pluginPath = File.join(Dir.tmpdir, "#{stem}_program.py") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
dynamic #{stem_program.py}
I need to fix the high-level tests that is failing |
Pull request overview
Companion PR:
Link to relevant GitHub Issue(s) if appropriate:
Link to the Ubuntu 22.04 .deb installer to use for CI Testing. If not set, it will default to latest official release.
[OpenStudio Installer]:http://openstudio-ci-builds.s3-website-us-west-2.amazonaws.com/PR-5312/OpenStudio-3.9.1-alpha%2B8c127f63e3-Ubuntu-22.04-x86_64.deb
This Pull Request is concerning:
NewTest
: a new test for a new model API class,TestFix
: a fix for an existing test. The GitHub issue should be referenced in the PR descriptionNewTestForExisting
: a new test for an already-existing model API classOther
: Something else, like maintenance of the repo, or just committing test results with a new OpenStudio version.Depending on your answer, please fill out the required section below, and delete the three others.
Leave the review checklist in place.
Case 1: New test for a new model API class
Please include which class(es) you are adding a test to specifically test for.
Include a link to the OpenStudio Pull Request in which you are adding the new classes, or the class itself if already on develop.
Work Checklist
The following has been checked to ensure compliance with the guidelines:
Tests pass either:
with official OpenStudio release (include version):
AddedOSM
has been added to this PRout.osw
have been committedwith current develop (incude SHA):
PendingOSM
has been added to this PRmodel_tests.rb
has a TODO.out.osw
have been committed as they need to be run with an official OpenStudio versionRuby test is stable: when run multiple times on the same machine, it produces the same total site kBTU.
Please paste the heatmap png generated after running the following commands:
model.getThermalZones.sort_by{|z| z.name.to_s}.each do ...
so I am sure I put the same ZoneHVAC systems to the same zones regardless of their order)process_results.py
(seepython process_results.py --help
for usage).Please paste the text output or heatmap png generated after running the following commands:
Object has been added to
autosize_hvac.rb
to ensure the autosizedXXX values methods do workReview Checklist
# TODO
added tomodel_tests.rb
out.osw
have been committedautosize_hvac
as appropriateNewTest
,TestFix
,NewTestForExisting
,Other
NewTest
: addPendingOSM
orAddedOSM