Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add extra new line before .local_cuda.bazelrc #1113

Merged
merged 2 commits into from
Oct 21, 2024
Merged

Conversation

gpupuck
Copy link
Contributor

@gpupuck gpupuck commented Oct 21, 2024

Sometimes when there is no new line at the end of .bazelrc file, it will end up with try-import %workspace%/.bazelrc.usertry-import %workspace%/.local_cuda.bazelrc.

For example this commit did not contain a new line at the end: jax-ml/jax@a2bc8c2

@gpupuck gpupuck requested review from nouiz and olupton October 21, 2024 18:24
`.bazelrc` sometimes could be updated without a new line at the end of the file, which would end up with two `try-import` in the same line
@gpupuck gpupuck changed the title Use pre-defined .bazelrc.user to save hermetic CUDA settings Add extra new line before .local_cuda.bazelrc Oct 21, 2024
Copy link
Collaborator

@nouiz nouiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, validate CI results.

@gpupuck gpupuck merged commit 2f73127 into main Oct 21, 2024
134 of 135 checks passed
@gpupuck gpupuck deleted the by/fix-bazelrc-import branch October 21, 2024 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants