-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump based CUDA image to ubuntu24.04 #1166
Conversation
@olupton desperately need your input here =) |
Some builds are still broken 😜 |
The latest changes includes the following:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks mostly good!
Could you please resurrect the .amd64
Dockerfiles, even though we are not using them by default at this time? The concern here is that our lingvo/tftext builds add too many boilerplates to the Dockerfile, and are not easily removable should one day we want to move back to use the upstream wheels. We need a reference here to remind us how simple things could be 😁
I don't understand everything you've changed, but I'm good with the changes made for |
Done |
…oolbox into vkozlov/move-to-ubuntu24.04
Ubuntu24.04 uses
python-3.12
as a main interpreter. Unfortunately, not all python packages, we use here, has py-3.12 wheel for amd64/arm64, so need to build the following packages from source:Also
python-3.12
added a system-wide protection layer (PEP 668) when install packages usingpip
:There are at least 2 possible solutions:
venv
(the initial solution was proposed by @olupton).PIP_BREAK_SYSTEM_PACKAGES=1
This branch contains both solutions, but collective mind and experience of PyTorch team suggests to finalize the second solution (system-wide installation)