Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only set CUDA_DEVICE_MAX_CONNECTIONS=1 for Hopper/cc9.0 runs #1236

Merged
merged 1 commit into from
Jan 10, 2025

Conversation

olupton
Copy link
Collaborator

@olupton olupton commented Jan 9, 2025

No description provided.

@olupton olupton force-pushed the olupton/25.01/max-connections branch from e6bf53b to 21bf29a Compare January 9, 2025 15:43
@gpupuck gpupuck self-requested a review January 10, 2025 16:51
@@ -221,7 +221,12 @@ pushd ${MAXTEXT_DIR}

export NVTE_FUSED_ATTN=${ENABLE_FUSED_ATTN}
export XLA_PYTHON_CLIENT_MEM_FRACTION=${MEM_FRACTION}
export CUDA_DEVICE_MAX_CONNECTIONS=1

local_arch=$(local_cuda_arch)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wasn't aware that local_cuda_arch is installed in /usr/local/bin.

@nouiz nouiz merged commit a13a946 into 25.01-devel Jan 10, 2025
121 of 138 checks passed
@nouiz nouiz deleted the olupton/25.01/max-connections branch January 10, 2025 19:17
@nouiz
Copy link
Collaborator

nouiz commented Jan 10, 2025

Note, we should also merge this in the main branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants