Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add enable_cudf_spill to LocalCudaCluster #268

Merged
merged 6 commits into from
Sep 30, 2024

Conversation

praateekmahajan
Copy link
Collaborator

@praateekmahajan praateekmahajan commented Sep 27, 2024

Description

Since rapidsai/dask-cuda#1362 is merged we don't need to rely on client.run(_enable_spilling) and can just pass that arg to LocalCUDACluster

Checklist

  • I am familiar with the Contributing Guide.
  • New or Existing tests cover these changes.
  • The documentation is up to date with these changes.

Signed-off-by: Praateek Mahajan <praateekm@gmail.com>
Signed-off-by: Praateek Mahajan <praateekm@gmail.com>
Signed-off-by: Praateek Mahajan <praateekm@gmail.com>
Copy link
Collaborator

@VibhuJawa VibhuJawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Praateek Mahajan <praateekm@gmail.com>
Signed-off-by: Praateek Mahajan <praateekm@gmail.com>
Signed-off-by: Praateek Mahajan <praateekm@gmail.com>
Copy link
Collaborator

@VibhuJawa VibhuJawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@praateekmahajan praateekmahajan merged commit 9af8da1 into NVIDIA:main Sep 30, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants