code review

NcStudios · Dec 2, 2023 · 1682fea · 1682fea
1 parent b447156
commit 1682fea
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 18 deletions.
diff --git a/include/ncutility/BinarySerialization.h b/include/ncutility/BinarySerialization.h
@@ -36,7 +36,7 @@ namespace nc::serialize
  *   - Trivially copyable types
  *   - Stl types: string, array, vector, unordered_map, pair, and optional
  *   - Aggregates with <= 16 members, each satisfying at least one
- *     of these requirements
+ *     of the above requirements
  */
 inline constexpr nc::serialize::cpo::SerializeFn Serialize;
 
@@ -48,4 +48,4 @@ inline constexpr nc::serialize::cpo::DeserializeFn Deserialize;
 
 /** @brief The maximum number of members an aggregate may have for default serialization. */
 inline constexpr size_t g_aggregateMaxMemberCount = 16ull;
-} // namespace nc::serizlize
+} // namespace nc::seriazlize
diff --git a/include/ncutility/detail/BinarySerializationDetail.h b/include/ncutility/detail/BinarySerializationDetail.h
@@ -35,31 +35,31 @@ template<class T>
 consteval auto MemberCount() -> size_t
 {
     using U = UniversalType;
-    if constexpr (requires { T{U{}, U{}, U{}, U{},  U{}, U{}, U{}, U{},  U{}, U{}, U{}, U{},  U{}, U{}, U{}, U{},  U{}}; })
+    if constexpr (requires { T{U{}, U{}, U{}, U{}, U{}, U{}, U{}, U{}, U{}, U{}, U{}, U{}, U{}, U{}, U{}, U{}, U{}}; })
         return g_failedMemberCount;
-    else if constexpr (requires { T{U{}, U{}, U{}, U{},  U{}, U{}, U{}, U{},  U{}, U{}, U{}, U{},  U{}, U{}, U{}, U{}}; })
+    else if constexpr (requires { T{U{}, U{}, U{}, U{}, U{}, U{}, U{}, U{}, U{}, U{}, U{}, U{}, U{}, U{}, U{}, U{}}; })
         return 16ull;
-    else if constexpr (requires { T{U{}, U{}, U{}, U{},  U{}, U{}, U{}, U{},  U{}, U{}, U{}, U{},  U{}, U{}, U{}}; })
+    else if constexpr (requires { T{U{}, U{}, U{}, U{}, U{}, U{}, U{}, U{}, U{}, U{}, U{}, U{}, U{}, U{}, U{}}; })
         return 15ull;
-    else if constexpr (requires { T{U{}, U{}, U{}, U{},  U{}, U{}, U{}, U{},  U{}, U{}, U{}, U{},  U{}, U{}}; })
+    else if constexpr (requires { T{U{}, U{}, U{}, U{}, U{}, U{}, U{}, U{}, U{}, U{}, U{}, U{}, U{}, U{}}; })
         return 14ull;
-    else if constexpr (requires { T{U{}, U{}, U{}, U{},  U{}, U{}, U{}, U{},  U{}, U{}, U{}, U{},  U{}}; })
+    else if constexpr (requires { T{U{}, U{}, U{}, U{}, U{}, U{}, U{}, U{}, U{}, U{}, U{}, U{}, U{}}; })
         return 13ull;
-    else if constexpr (requires { T{U{}, U{}, U{}, U{},  U{}, U{}, U{}, U{},  U{}, U{}, U{}, U{}}; })
+    else if constexpr (requires { T{U{}, U{}, U{}, U{}, U{}, U{}, U{}, U{}, U{}, U{}, U{}, U{}}; })
         return 12ull;
-    else if constexpr (requires { T{U{}, U{}, U{}, U{},  U{}, U{}, U{}, U{},  U{}, U{}, U{}}; })
+    else if constexpr (requires { T{U{}, U{}, U{}, U{}, U{}, U{}, U{}, U{}, U{}, U{}, U{}}; })
         return 11ull;
-    else if constexpr (requires { T{U{}, U{}, U{}, U{},  U{}, U{}, U{}, U{},  U{}, U{}}; })
+    else if constexpr (requires { T{U{}, U{}, U{}, U{}, U{}, U{}, U{}, U{}, U{}, U{}}; })
         return 10ull;
-    else if constexpr (requires { T{U{}, U{}, U{}, U{},  U{}, U{}, U{}, U{},  U{}}; })
+    else if constexpr (requires { T{U{}, U{}, U{}, U{}, U{}, U{}, U{}, U{}, U{}}; })
         return 9ull;
-    else if constexpr (requires { T{U{}, U{}, U{}, U{},  U{}, U{}, U{}, U{}}; })
+    else if constexpr (requires { T{U{}, U{}, U{}, U{}, U{}, U{}, U{}, U{}}; })
         return 8ull;
-    else if constexpr (requires { T{U{}, U{}, U{}, U{},  U{}, U{}, U{}}; })
+    else if constexpr (requires { T{U{}, U{}, U{}, U{}, U{}, U{}, U{}}; })
         return 7ull;
-    else if constexpr (requires { T{U{}, U{}, U{}, U{},  U{}, U{}}; })
+    else if constexpr (requires { T{U{}, U{}, U{}, U{}, U{}, U{}}; })
         return 6ull;
-    else if constexpr (requires { T{U{}, U{}, U{}, U{},  U{}}; })
+    else if constexpr (requires { T{U{}, U{}, U{}, U{}, U{}}; })
         return 5ull;
     else if constexpr (requires { T{U{}, U{}, U{}, U{}}; })
         return 4ull;
@@ -82,9 +82,6 @@ concept UnpackableAggregate = Aggregate<T>
 template<class T>
 void Serialize(std::ostream& stream, const T& in);
 
-template<class T>
-void Deserialize(std::istream& stream, T& out);
-
 template<TriviallyCopyable T>
 void Serialize(std::ostream& stream, const T& in);
 
@@ -106,6 +103,9 @@ void Serialize(std::ostream& stream, const std::unordered_map<K, V>& in);
 template<class T>
 void Serialize(std::ostream& stream, const std::optional<T>& in);
 
+template<class T>
+void Deserialize(std::istream& stream, T& out);
+
 template<TriviallyCopyable T>
 void Deserialize(std::istream& stream, T& in);