Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't throw an exception but emit a warn when jcr:content node is not #28

Merged

Conversation

kwin
Copy link
Member

@kwin kwin commented Oct 16, 2024

found at all

This closes #27

@kwin kwin requested a review from jmagdrod October 16, 2024 13:22
Copy link

github-actions bot commented Oct 16, 2024

Test report (macos-latest, JDK 17)

2 tests  ±0   2 ✅ ±0   5s ⏱️ -5s
2 suites ±0   0 💤 ±0 
2 files   ±0   0 ❌ ±0 

Results for commit 40f8bcf. ± Comparison against base commit 9122750.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Oct 16, 2024

Test report (ubuntu-latest, JDK 21)

2 tests  ±0   2 ✅ ±0   7s ⏱️ -2s
2 suites ±0   0 💤 ±0 
2 files   ±0   0 ❌ ±0 

Results for commit 40f8bcf. ± Comparison against base commit 9122750.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Oct 16, 2024

Test report (ubuntu-latest, JDK 11)

2 tests  ±0   2 ✅ ±0   7s ⏱️ -2s
2 suites ±0   0 💤 ±0 
2 files   ±0   0 ❌ ±0 

Results for commit 40f8bcf. ± Comparison against base commit 9122750.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Oct 16, 2024

Test report (macos-latest, JDK 11)

2 tests  ±0   2 ✅ ±0   5s ⏱️ ±0s
2 suites ±0   0 💤 ±0 
2 files   ±0   0 ❌ ±0 

Results for commit 40f8bcf. ± Comparison against base commit 9122750.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Oct 16, 2024

Test report (macos-latest, JDK 21)

2 tests  ±0   2 ✅ ±0   3s ⏱️ -6s
2 suites ±0   0 💤 ±0 
2 files   ±0   0 ❌ ±0 

Results for commit 40f8bcf. ± Comparison against base commit 9122750.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Oct 16, 2024

Test report (ubuntu-latest, JDK 17)

2 tests  ±0   2 ✅ ±0   10s ⏱️ -3s
2 suites ±0   0 💤 ±0 
2 files   ±0   0 ❌ ±0 

Results for commit 40f8bcf. ± Comparison against base commit 9122750.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Oct 16, 2024

Test report (windows-latest, JDK 11)

2 tests  ±0   2 ✅ ±0   11s ⏱️ -12s
2 suites ±0   0 💤 ±0 
2 files   ±0   0 ❌ ±0 

Results for commit 40f8bcf. ± Comparison against base commit 9122750.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Oct 16, 2024

Test report (windows-latest, JDK 21)

2 tests  ±0   2 ✅ ±0   13s ⏱️ -6s
2 suites ±0   0 💤 ±0 
2 files   ±0   0 ❌ ±0 

Results for commit 40f8bcf. ± Comparison against base commit 9122750.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Oct 16, 2024

Test report (windows-latest, JDK 17)

2 tests  ±0   2 ✅ ±0   9s ⏱️ -17s
2 suites ±0   0 💤 ±0 
2 files   ±0   0 ❌ ±0 

Results for commit 40f8bcf. ± Comparison against base commit 9122750.

♻️ This comment has been updated with latest results.

@kwin kwin force-pushed the bugfix/improve-error-message-for-missing-jcr-content-node branch from 2703b35 to 40f8bcf Compare October 16, 2024 13:25
@kwin kwin merged commit 1a89d8a into main Oct 25, 2024
18 checks passed
@kwin kwin deleted the bugfix/improve-error-message-for-missing-jcr-content-node branch October 25, 2024 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve exception messages for pages without jcr:content child node
1 participant