Add available gas and user args #677
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oMemory hint when gas present
cicr99
reviewed
Dec 18, 2024
…rence in the integration tests with args
cicr99
reviewed
Dec 20, 2024
cicr99
approved these changes
Dec 20, 2024
…incremented by mainFuncOffset, writing user args to the AP in the hint
* Bump go version from 1.20 -> 1.21 * Update golangci-lint
…NethermindEth/cairo-vm-go into add_available_gas_and_user_args
MaksymMalicki
added a commit
that referenced
this pull request
Jan 10, 2025
* Fixes for the generation of entry code, fixes of hints parsing * Add modifications to the runner * Add fixes for the entrycode generation * Refactor main CLI, offset the hints indexes by entry code size, load arguments and initial gas to the memory * Add available gas and user args (#677) * Add parsing logic for input user args * Add flags for available gas, input user args, writing args to memory * Fix unit tests for user arguments parsing * Lint the PR * Add user args to hint context * Refactor the code * Fix unconditional append of ExternalWriteArgsToMemory, bug fixes in integration tests * Add fixes of the call size calculation and include ExternalWriteArgsToMemory hint when gas present * Add layouts for integration tests * Add error handling * Fixes in entry code generation * Address changes mentioned in a discussion * Add comment regarding writing to memory in a hint for the future reference in the integration tests with args * Changes in calculations of the initial PC offset, CALL opcode offset incremented by mainFuncOffset, writing user args to the AP in the hint * Turn back VM config to private field * Add error handling on assign of `userArgs` to the initial scope * Lint project * Bump go version from 1.20 -> 1.21 (#678) * Bump go version from 1.20 -> 1.21 * Update golangci-lint * Simplify the Makefile * Correction in the makefile * Fix the integration tests * Fixes in the runner * Fixes in the runner * Fix the unit tests, uncomment pythonVm execution in integration tests, code cleanups * Add writing tokens gas cost to memory * Proper builtins initialization for cairo mode * Address comments in the PR * Removed systemtype from builtins
MaksymMalicki
added a commit
that referenced
this pull request
Jan 10, 2025
* Fixes for the generation of entry code, fixes of hints parsing * Add modifications to the runner * Add fixes for the entrycode generation * Refactor main CLI, offset the hints indexes by entry code size, load arguments and initial gas to the memory * Add available gas and user args (#677) * Add parsing logic for input user args * Add flags for available gas, input user args, writing args to memory * Fix unit tests for user arguments parsing * Lint the PR * Add user args to hint context * Refactor the code * Fix unconditional append of ExternalWriteArgsToMemory, bug fixes in integration tests * Add fixes of the call size calculation and include ExternalWriteArgsToMemory hint when gas present * Add layouts for integration tests * Add error handling * Fixes in entry code generation * Address changes mentioned in a discussion * Add comment regarding writing to memory in a hint for the future reference in the integration tests with args * Changes in calculations of the initial PC offset, CALL opcode offset incremented by mainFuncOffset, writing user args to the AP in the hint * Turn back VM config to private field * Add error handling on assign of `userArgs` to the initial scope * Lint project * Bump go version from 1.20 -> 1.21 (#678) * Bump go version from 1.20 -> 1.21 * Update golangci-lint * Simplify the Makefile * Correction in the makefile * Fix the integration tests * Fixes in the runner * Fixes in the runner * Fix the unit tests, uncomment pythonVm execution in integration tests, code cleanups * Add writing tokens gas cost to memory * Proper builtins initialization for cairo mode * Add fixes for hints, change the order of tokens in gas.go * Address comments in the PR * gofmt * remove systemtype builtin
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the following changes:
CALLopcode in the entry code (incremented by the offset of the main fuction)AP, instead ofAP - len(userArgs)