-
-
Notifications
You must be signed in to change notification settings - Fork 269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[17.0][MIG] sale_variant_configurator: Migration to 17.0 #381
Open
HeliconiaSolutions
wants to merge
25
commits into
OCA:17.0
Choose a base branch
from
HeliconiaIO:17.0-mig-sale_variant_configurator
base: 17.0
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[17.0][MIG] sale_variant_configurator: Migration to 17.0 #381
HeliconiaSolutions
wants to merge
25
commits into
OCA:17.0
from
HeliconiaIO:17.0-mig-sale_variant_configurator
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comes from module sale_product_variants from odoomrp/odoomrp-wip.
- saleable products for Sale Orders. - purchable products for Purchase Orders.
Depending on the onchange order loaded in runtime, description put in the SO line might be the one got from the regular way. With this, we assure we get the proper description, and also in the partner language (using the trick with the partner field).
* Use generic method for creating the variant if needed * Create the variant when the sales is already confirmed
for some reason, after the creation of the product, the sale.order.line was emptied (e.g. product_tmpl_id was False) -> the onchange would do nothing. I split the test in two, and in the second test, I create the product before creating the sale order line.
…omer language As the model `sale.order.line` doesn't have `partner_id` field, the description is not populated in the customer language, as the automatism put in product_configurator makes use of this trick. For not adding such field that can conflict with other parts, let's overwrite the methods that populate the description and pass upstream the customer language in the context. TT33029
Currently translated at 100.0% (8 of 8 strings) Translation: product-variant-16.0/product-variant-16.0-sale_variant_configurator Translate-URL: https://translation.odoo-community.org/projects/product-variant-16-0/product-variant-16-0-sale_variant_configurator/pt_BR/
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.