Skip to content

Commit

Permalink
[MIG] web_theme_classic from 16.0 to 17.0
Browse files Browse the repository at this point in the history
  • Loading branch information
legalsylvain committed Nov 15, 2023
1 parent 45dca0a commit 4fec72d
Show file tree
Hide file tree
Showing 5 changed files with 54 additions and 74 deletions.
18 changes: 9 additions & 9 deletions web_theme_classic/README.rst
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ Web Theme Classic
!! This file is generated by oca-gen-addon-readme !!
!! changes will be overwritten. !!
!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
!! source digest: sha256:080d86ef900f4f27baf1f53f92e407247e033c7b14a46667d53597711605af32
!! source digest: sha256:b309e66df73fcf5de5629e2cc3645e23340d22335fcd405f771e5cce15341741
!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
.. |badge1| image:: https://img.shields.io/badge/maturity-Beta-yellow.png
Expand All @@ -17,13 +17,13 @@ Web Theme Classic
:target: http://www.gnu.org/licenses/agpl-3.0-standalone.html
:alt: License: AGPL-3
.. |badge3| image:: https://img.shields.io/badge/github-OCA%2Fweb-lightgray.png?logo=github
:target: https://github.com/OCA/web/tree/16.0/web_theme_classic
:target: https://github.com/OCA/web/tree/17.0/web_theme_classic
:alt: OCA/web
.. |badge4| image:: https://img.shields.io/badge/weblate-Translate%20me-F47D42.png
:target: https://translation.odoo-community.org/projects/web-16-0/web-16-0-web_theme_classic
:target: https://translation.odoo-community.org/projects/web-17-0/web-17-0-web_theme_classic
:alt: Translate me on Weblate
.. |badge5| image:: https://img.shields.io/badge/runboat-Try%20me-875A7B.png
:target: https://runboat.odoo-community.org/builds?repo=OCA/web&target_branch=16.0
:target: https://runboat.odoo-community.org/builds?repo=OCA/web&target_branch=17.0
:alt: Try me on Runboat

|badge1| |badge2| |badge3| |badge4| |badge5|
Expand All @@ -32,7 +32,7 @@ This module extend the Odoo Community Edition ``web`` module to improve visibili
of form view.

**Rational:**
In Odoo V16, the design is very pure. That's great, but it generates some problem for
Since Odoo V17, the design is very pure. That's great, but it generates some problem for
users :

* buttons and fields are not identifiable. (we can not know exactly where there are
Expand All @@ -44,11 +44,11 @@ In a way, this module restores the form display of version 15, but preserving th

**Without this module**

.. figure:: https://raw.githubusercontent.com/OCA/web/16.0/web_theme_classic/static/description/product_template_form_without_module.png
.. figure:: https://raw.githubusercontent.com/OCA/web/17.0/web_theme_classic/static/description/product_template_form_without_module.png

**With this module**

.. figure:: https://raw.githubusercontent.com/OCA/web/16.0/web_theme_classic/static/description/product_template_form_with_module.png
.. figure:: https://raw.githubusercontent.com/OCA/web/17.0/web_theme_classic/static/description/product_template_form_with_module.png

**Table of contents**

Expand All @@ -67,7 +67,7 @@ Bug Tracker
Bugs are tracked on `GitHub Issues <https://github.com/OCA/web/issues>`_.
In case of trouble, please check there if your issue has already been reported.
If you spotted it first, help us to smash it by providing a detailed and welcomed
`feedback <https://github.com/OCA/web/issues/new?body=module:%20web_theme_classic%0Aversion:%2016.0%0A%0A**Steps%20to%20reproduce**%0A-%20...%0A%0A**Current%20behavior**%0A%0A**Expected%20behavior**>`_.
`feedback <https://github.com/OCA/web/issues/new?body=module:%20web_theme_classic%0Aversion:%2017.0%0A%0A**Steps%20to%20reproduce**%0A-%20...%0A%0A**Current%20behavior**%0A%0A**Expected%20behavior**>`_.

Do not contact contributors directly about support or help with technical issues.

Expand Down Expand Up @@ -105,6 +105,6 @@ Current `maintainer <https://odoo-community.org/page/maintainer-role>`__:

|maintainer-legalsylvain|

This module is part of the `OCA/web <https://github.com/OCA/web/tree/16.0/web_theme_classic>`_ project on GitHub.
This module is part of the `OCA/web <https://github.com/OCA/web/tree/17.0/web_theme_classic>`_ project on GitHub.

You are welcome to contribute. To learn how please visit https://odoo-community.org/page/Contribute.
2 changes: 1 addition & 1 deletion web_theme_classic/__manifest__.py
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
{
"name": "Web Theme Classic",
"summary": "Contrasted style on fields to improve the UI.",
"version": "16.0.1.0.2",
"version": "17.0.1.0.0",
"author": "GRAP, Odoo Community Association (OCA)",
"maintainers": ["legalsylvain"],
"website": "https://github.com/OCA/web",
Expand Down
2 changes: 1 addition & 1 deletion web_theme_classic/readme/DESCRIPTION.rst
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ This module extend the Odoo Community Edition ``web`` module to improve visibili
of form view.

**Rational:**
In Odoo V16, the design is very pure. That's great, but it generates some problem for
Since Odoo V17, the design is very pure. That's great, but it generates some problem for
users :

* buttons and fields are not identifiable. (we can not know exactly where there are
Expand Down
14 changes: 7 additions & 7 deletions web_theme_classic/static/description/index.html
Original file line number Diff line number Diff line change
Expand Up @@ -367,13 +367,13 @@ <h1 class="title">Web Theme Classic</h1>
!! This file is generated by oca-gen-addon-readme !!
!! changes will be overwritten. !!
!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
!! source digest: sha256:080d86ef900f4f27baf1f53f92e407247e033c7b14a46667d53597711605af32
!! source digest: sha256:b309e66df73fcf5de5629e2cc3645e23340d22335fcd405f771e5cce15341741
!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! -->
<p><a class="reference external image-reference" href="https://odoo-community.org/page/development-status"><img alt="Beta" src="https://img.shields.io/badge/maturity-Beta-yellow.png" /></a> <a class="reference external image-reference" href="http://www.gnu.org/licenses/agpl-3.0-standalone.html"><img alt="License: AGPL-3" src="https://img.shields.io/badge/licence-AGPL--3-blue.png" /></a> <a class="reference external image-reference" href="https://github.com/OCA/web/tree/16.0/web_theme_classic"><img alt="OCA/web" src="https://img.shields.io/badge/github-OCA%2Fweb-lightgray.png?logo=github" /></a> <a class="reference external image-reference" href="https://translation.odoo-community.org/projects/web-16-0/web-16-0-web_theme_classic"><img alt="Translate me on Weblate" src="https://img.shields.io/badge/weblate-Translate%20me-F47D42.png" /></a> <a class="reference external image-reference" href="https://runboat.odoo-community.org/builds?repo=OCA/web&amp;target_branch=16.0"><img alt="Try me on Runboat" src="https://img.shields.io/badge/runboat-Try%20me-875A7B.png" /></a></p>
<p><a class="reference external image-reference" href="https://odoo-community.org/page/development-status"><img alt="Beta" src="https://img.shields.io/badge/maturity-Beta-yellow.png" /></a> <a class="reference external image-reference" href="http://www.gnu.org/licenses/agpl-3.0-standalone.html"><img alt="License: AGPL-3" src="https://img.shields.io/badge/licence-AGPL--3-blue.png" /></a> <a class="reference external image-reference" href="https://github.com/OCA/web/tree/17.0/web_theme_classic"><img alt="OCA/web" src="https://img.shields.io/badge/github-OCA%2Fweb-lightgray.png?logo=github" /></a> <a class="reference external image-reference" href="https://translation.odoo-community.org/projects/web-17-0/web-17-0-web_theme_classic"><img alt="Translate me on Weblate" src="https://img.shields.io/badge/weblate-Translate%20me-F47D42.png" /></a> <a class="reference external image-reference" href="https://runboat.odoo-community.org/builds?repo=OCA/web&amp;target_branch=17.0"><img alt="Try me on Runboat" src="https://img.shields.io/badge/runboat-Try%20me-875A7B.png" /></a></p>
<p>This module extend the Odoo Community Edition <tt class="docutils literal">web</tt> module to improve visibility
of form view.</p>
<p><strong>Rational:</strong>
In Odoo V16, the design is very pure. That’s great, but it generates some problem for
Since Odoo V17, the design is very pure. That’s great, but it generates some problem for
users :</p>
<ul class="simple">
<li>buttons and fields are not identifiable. (we can not know exactly where there are
Expand All @@ -383,11 +383,11 @@ <h1 class="title">Web Theme Classic</h1>
<p>In a way, this module restores the form display of version 15, but preserving the “save on the fly” new feature.</p>
<p><strong>Without this module</strong></p>
<div class="figure">
<img alt="https://raw.githubusercontent.com/OCA/web/16.0/web_theme_classic/static/description/product_template_form_without_module.png" src="https://raw.githubusercontent.com/OCA/web/16.0/web_theme_classic/static/description/product_template_form_without_module.png" />
<img alt="https://raw.githubusercontent.com/OCA/web/17.0/web_theme_classic/static/description/product_template_form_without_module.png" src="https://raw.githubusercontent.com/OCA/web/17.0/web_theme_classic/static/description/product_template_form_without_module.png" />
</div>
<p><strong>With this module</strong></p>
<div class="figure">
<img alt="https://raw.githubusercontent.com/OCA/web/16.0/web_theme_classic/static/description/product_template_form_with_module.png" src="https://raw.githubusercontent.com/OCA/web/16.0/web_theme_classic/static/description/product_template_form_with_module.png" />
<img alt="https://raw.githubusercontent.com/OCA/web/17.0/web_theme_classic/static/description/product_template_form_with_module.png" src="https://raw.githubusercontent.com/OCA/web/17.0/web_theme_classic/static/description/product_template_form_with_module.png" />
</div>
<p><strong>Table of contents</strong></p>
<div class="contents local topic" id="contents">
Expand All @@ -414,7 +414,7 @@ <h1><a class="toc-backref" href="#toc-entry-2">Bug Tracker</a></h1>
<p>Bugs are tracked on <a class="reference external" href="https://github.com/OCA/web/issues">GitHub Issues</a>.
In case of trouble, please check there if your issue has already been reported.
If you spotted it first, help us to smash it by providing a detailed and welcomed
<a class="reference external" href="https://github.com/OCA/web/issues/new?body=module:%20web_theme_classic%0Aversion:%2016.0%0A%0A**Steps%20to%20reproduce**%0A-%20...%0A%0A**Current%20behavior**%0A%0A**Expected%20behavior**">feedback</a>.</p>
<a class="reference external" href="https://github.com/OCA/web/issues/new?body=module:%20web_theme_classic%0Aversion:%2017.0%0A%0A**Steps%20to%20reproduce**%0A-%20...%0A%0A**Current%20behavior**%0A%0A**Expected%20behavior**">feedback</a>.</p>
<p>Do not contact contributors directly about support or help with technical issues.</p>
</div>
<div class="section" id="credits">
Expand All @@ -440,7 +440,7 @@ <h2><a class="toc-backref" href="#toc-entry-6">Maintainers</a></h2>
promote its widespread use.</p>
<p>Current <a class="reference external" href="https://odoo-community.org/page/maintainer-role">maintainer</a>:</p>
<p><a class="reference external image-reference" href="https://github.com/legalsylvain"><img alt="legalsylvain" src="https://github.com/legalsylvain.png?size=40px" /></a></p>
<p>This module is part of the <a class="reference external" href="https://github.com/OCA/web/tree/16.0/web_theme_classic">OCA/web</a> project on GitHub.</p>
<p>This module is part of the <a class="reference external" href="https://github.com/OCA/web/tree/17.0/web_theme_classic">OCA/web</a> project on GitHub.</p>
<p>You are welcome to contribute. To learn how please visit <a class="reference external" href="https://odoo-community.org/page/Contribute">https://odoo-community.org/page/Contribute</a>.</p>
</div>
</div>
Expand Down
92 changes: 36 additions & 56 deletions web_theme_classic/static/src/scss/web_theme_classic.scss
Original file line number Diff line number Diff line change
Expand Up @@ -13,84 +13,64 @@ $button-border-color: #dee2e6;
Form View : Handle Fields Borders
************************************************************/

.o_input,
.o_field_html > .note-editable {
/* Add border for all editable fields */
border: 1px solid $input-border-color !important;
border-radius: 3px;

/* add darker border on focus */
&:focus {
border-color: $input-border-color-focus !important;
.o_form_view {
.o_input,
.o_field_html > .note-editable {
/* Add border for all editable fields */
border: 1px solid $input-border-color !important;
border-radius: 3px;

/* add darker border on focus */
&:focus {
border-color: $input-border-color-focus !important;
}
}
}

.o_field_many2many_selection {
.o_input {
/* Prevent to have double border for many2many tags input fields */
border: 0px solid !important;
.o_field_many2many_selection {
.o_input {
/* Prevent to have double border for many2many tags input fields */
border: 0px solid !important;
}
}
}

/***********************************************************
Form View : Handle Button Borders
************************************************************/

.btn-secondary,
.btn-light {
border-color: $button-border-color;
}

.btn-light {
&:hover {
.o_form_view {
.btn-light {
border-color: $button-border-color;
}
}

.btn-light {
&:hover {
border-color: $button-border-color;
}
}
}
/***********************************************************
Form View : Handle Background for required fields
************************************************************/

.o_required_modifier:not(.o_readonly_modifier) {
.o_input {
/* Add background for all editable and required fields */
background-color: $input-background-color-required !important;
.o_form_view {
.o_required_modifier:not(.o_readonly_modifier) {
.o_input {
/* Add background for all editable and required fields */
background-color: $input-background-color-required !important;

/* darker placeholder as the background is darker */
&::placeholder {
color: $input-color-placeholder-required;
/* darker placeholder as the background is darker */
&::placeholder {
color: $input-color-placeholder-required;
}
}
}
}

.o_required_modifier.o_field_selection:not(.o_readonly_modifier) {
/* Specific case for field selection */
background-color: $input-background-color-required !important;
}

/***********************************************************
Search View : Search Bar Input
************************************************************/
div.o_searchview[role="search"] {
/* Add border for the searchable zone */
border: 1px solid $input-border-color !important;
border-radius: 3px;

/* add darker border when input inside has focus */
&:focus-within {
border-color: $input-border-color-focus !important;
.o_required_modifier.o_field_selection:not(.o_readonly_modifier) {
/* Specific case for field selection */
background-color: $input-background-color-required !important;
}
}

/* Adjust padding to avoid items to be sticked to borders */
div.o_searchview_facet[role="img"] {
padding-left: 2px;
}

i.o_searchview_icon[role="img"] {
padding-right: 2px;
}

/***********************************************************
Tree View : Handle style for required fields
************************************************************/
Expand Down

0 comments on commit 4fec72d

Please sign in to comment.