Server multi restart issue fix #466
Conversation
Signed-off-by: Arun Venmany <Arun.Kumar.V.N@ibm.com>
Signed-off-by: Arun Venmany <Arun.Kumar.V.N@ibm.com>
| @@ -4021,15 +4049,27 @@ private void initWatchLoop() throws IOException { | |||
| // initial source and test compile of upstream projects | |||
| if (isMultiModuleProject()) { | |||
| for (ProjectModule project : upstreamProjects) { | |||
| triggerUpstreamModuleCompile(project, false); | |||
| // if map is empty, should trigger compile | |||
| if (projectRecompileMap.isEmpty() || Boolean.TRUE.equals(projectRecompileMap.get(project.getProjectName())) ) { | |||
There was a problem hiding this comment.
When exactly can the map be empty? 1) When called from Gradle? If so, the info message at 4054 may be misleading? 2) When no project was identified as needing to be recompiled in Maven? If so, why would we do a recompile here?
There was a problem hiding this comment.
Map can be empty when passed from gradle.
Gradle is already using Gradle task state to check whether a recompile is required. Hence even if we always trigger compile from our end, it just returns task state as EVERYTHING UP-TO-DATE
There was a problem hiding this comment.
But can't it also be empty coming from Maven if no projects had compile errors?
There was a problem hiding this comment.
And since the answer for 1 is yes, my comment about the misleading messages applies.
| triggerMainModuleCompile(false); | ||
| // build file tracking of main project | ||
| // if map is empty, should trigger compile | ||
| if (projectRecompileMap.isEmpty()|| Boolean.TRUE.equals(projectRecompileMap.get(getProjectName())) ) { |
There was a problem hiding this comment.
Same comment about what an empty projectRecompileMap means and how it should affect the info messages.
Signed-off-by: Arun Venmany <Arun.Kumar.V.N@ibm.com>
No description provided.