Switch Community to gradle #77
Conversation
cswhite2000
force-pushed
the
gradle
branch
2 times, most recently
from
e71f2fd to
e80b7cd
Compare
Signed-off-by: Christopher White <18whitechristop@gmail.com>
|
I believe the build is failing due to not having the latest version of pgm in repo.pgm.fyi |
|
Updated! |
|
@cswhite2000 any other changes you'd like to make, or ready to merge? |
| compileOnly("tc.oc.occ:Environment:1.0.0-SNAPSHOT") | ||
| } | ||
|
|
||
| group = "dev.pgm" |
There was a problem hiding this comment.
| group = "dev.pgm" | |
| group = "dev.pgm.community" |
There was a problem hiding this comment.
@applenick This would change the distribution name to lowercase, from dev.pgm.Community to dev.pgm.community. I think this makes sense for consistency across all PGMDev projects: I changed it in Events, and all of PGM's publishing (albeit under tc.oc) is lowercase as well.
| implementation("tc.oc.pgm:util:0.16-SNAPSHOT") { isTransitive = false } | ||
| implementation("com.zaxxer:HikariCP:2.4.1") { isTransitive = false } | ||
| implementation("fr.minuskube.inv:smart-invs:1.2.7") { isTransitive = false } | ||
|
|
There was a problem hiding this comment.
In the PR for Events (and Ingame), I needed to add cloud-annotations as an implementation to avoid class file for org.apiguardian.api.API$Status not found warnings; not sure if that is the correct solution there but this is something I also notice here
edit: compileOnly is the correct solution.
| repositories { | ||
| maven { | ||
| name = "pgm-repo-snapshots" | ||
| url = uri("https://repo.pgm.fyi/snapshots") |
There was a problem hiding this comment.
Publishing did not appear to be set up for the workflow previously; this likely does not work with the current workflow setup.
PGM publishes GitHub packages which seems appropriate to do here until publishing to repo.pgm.fyi can be set up later.
Switches Community from PGM to Gradle
Jar contents are very similar
Maven: 2.7M
Gradle: 2.6M
Gradle isn't shading the old
co.aikarcommand dependencies, so I switched theCommandPermissionforPermissionI'm not sure how to test the distribution management configuration