Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add party chat and party list all command #78

Closed
wants to merge 1 commit into from

Conversation

Pugzy
Copy link
Contributor

@Pugzy Pugzy commented Nov 24, 2024

Also updates usage of new style ChannelMessageEvent

@Pugzy Pugzy marked this pull request as ready for review December 1, 2024 11:18
@Pablete1234 Pablete1234 requested a review from applenick December 1, 2024 11:19
@applenick
Copy link
Member

Resolved the issue: GSON was unable to serialize Channel<?>, so I converted it to a string using the display name. Since it’s only used to check if it’s an admin channel, I’d say this was the simplest fix. The main commit wasn’t signed, so I pushed it directly to the dev branch.

Thanks again for your work on this Pugzy! Feel free to open another PR if there was anything else you wanted to include. 👍

@applenick applenick closed this Dec 9, 2024
@Pugzy Pugzy deleted the party-chat branch December 11, 2024 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants