Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Actions & Trigger, Dye Colors, & add Sounds #110

Merged
merged 1 commit into from
Nov 6, 2023

Conversation

TheRealPear
Copy link
Contributor

Actions & Triggers

  • Changed descriptions on some table entries to clarify features some more
  • Documented play-sound action (resolves Document Play Sound Action #104)
  • Fixed indentation to be 4-spaces instead of 2-spaces in example XML.

The only thing yet to be done is adding more examples to demonstrate each action. Pablo has already given me some resources to quickly put some together, however, this is the most time-consuming part for me.

Sound Presets

Created a new page showing a list of sound presets that PGM ships with, allowing users to re-use it for a play-sound action. I've already linked to it from the new table in the Actions & Trigger page and it can be found under Reference > Misc from the navigation bar.

The only thing left in this area is to document all the possible sound key values in Minecraft 1.8, or at least provide a link where it'll be organized in a table similarly to PGM sound presets.

image

Dye Colors

Added some description to when and where you can use dye colors in a standard map.xml file. I've also added a new column to the table to show the corresponding block damage value (which is also consistent across stained clay, stained glass block/panes, and wools) for each dye color when using the team-color attribute.

image

docs/reference/misc/sounds.mdx Outdated Show resolved Hide resolved
docs/reference/misc/sounds.mdx Outdated Show resolved Hide resolved
docs/reference/misc/sounds.mdx Show resolved Hide resolved
Signed-off-by: TheRealPear <20259871+TheRealPear@users.noreply.github.com>
@TheRealPear
Copy link
Contributor Author

Added a link with a table of Sound Keys values and updated the Actions page to show it as well.

I think it would be a better idea for me (or someone else) to do a separate pull request for adding examples, though. It's an entirely different project to go through.

@TheRealPear TheRealPear marked this pull request as ready for review November 4, 2023 19:15
@CoWinkKeyDinkInc
Copy link
Collaborator

Fair enough.

@CoWinkKeyDinkInc CoWinkKeyDinkInc merged commit b4bb5e3 into PGMDev:master Nov 6, 2023
3 checks passed
@TheRealPear TheRealPear deleted the play-sound branch November 6, 2023 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

Document Play Sound Action
2 participants