Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Node 18 #100

Open
wants to merge 21 commits into
base: master
Choose a base branch
from
Open

Update to Node 18 #100

wants to merge 21 commits into from

Conversation

Pimentoso
Copy link
Owner

@Pimentoso Pimentoso commented Jun 15, 2023

This is for updating the main libraries. The main driving cause for this, is that the old Node version was not installable on ARM Macs, so I couldn't release updates for Mac.

Updates include

  • Node to 18.14.2
  • Electron to 17.0.0
  • Johnny-five to latest repo version (until they make a proper release with updated serialport)
  • serialport to 10.5.0

Notes

  • App is still not compliant with context isolation. I need to find a johnny-five example that uses context isolation but they don't exist AFAIK
  • electron-settings is still on 3.0.0 because newer versions require removing it from the renderer process
  • includes Cleanup code - remove playerTimes variable #98

TODOs

# Conflicts:
#	js/storage.js
#	package-lock.json
#	window.js
@Pimentoso Pimentoso self-assigned this Jun 16, 2023
@Pimentoso Pimentoso added the help wanted Extra attention is needed label Jun 26, 2023
@Pimentoso
Copy link
Owner Author

This is now blocked, the program compiles and starts, but as soon as the arduino is connected to the USB port, it starts raising the error again.
An issue has been opened on the J5 repo to ask for info. rwaldron/johnny-five#1825

@Pimentoso Pimentoso added blocked and removed help wanted Extra attention is needed labels Jun 26, 2023
# Conflicts:
#	js/client.js
#	js/main.js
#	js/utils.js
#	package-lock.json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant