-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue #515: Add ColumnStats Schema for JSON parsing #522
Open
osopardo1
wants to merge
8
commits into
Qbeast-io:main
Choose a base branch
from
osopardo1:515-float-columnStats
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+473
−44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
osopardo1
changed the title
Issue #515: Introduce ColumnStats schema for parsing
Issue #515: Add ColumnStats Schema for JSON parsing
Dec 16, 2024
# Conflicts: # core/src/main/scala/io/qbeast/spark/index/SparkRevisionFactory.scala # src/main/scala/io/qbeast/table/IndexedTable.scala # src/test/scala/io/qbeast/spark/index/SparkRevisionFactoryTest.scala
osopardo1
requested review from
Jiaweihu08
and removed request for
Jiaweihu08
December 20, 2024 07:58
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #522 +/- ##
=======================================
Coverage 88.50% 88.50%
=======================================
Files 21 21
Lines 774 774
Branches 115 115
=======================================
Hits 685 685
Misses 89 89 ☔ View full report in Codecov by Sentry. |
…am to the builder
Jiaweihu08
requested changes
Jan 9, 2025
core/src/main/scala/io/qbeast/core/model/QbeastColumnStats.scala
Outdated
Show resolved
Hide resolved
core/src/main/scala/io/qbeast/core/model/QbeastColumnStats.scala
Outdated
Show resolved
Hide resolved
core/src/main/scala/io/qbeast/core/model/QbeastColumnStats.scala
Outdated
Show resolved
Hide resolved
core/src/main/scala/io/qbeast/core/model/QbeastColumnStats.scala
Outdated
Show resolved
Hide resolved
core/src/main/scala/io/qbeast/spark/index/SparkRevisionFactory.scala
Outdated
Show resolved
Hide resolved
src/test/scala/io/qbeast/spark/index/SparkRevisionChangesUtilsTest.scala
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #515 .
In this PR, we are adding a way of building a
columnStats
Schema using the current columnTransformers
and the actualSchema
of the Data. We want to:For that, I've added a
QbeastColumnStats
case class that contains thecolumnStatsSchema
and thecolumnStatsRow
. Also, aQbeastColumnStatsBuilder
is needed to retrieve all the information given the parameters mentioned above.Type of change
Bug fix.
Checklist:
Here is the list of things you should do before submitting this pull request:
How Has This Been Tested? (Optional)
Testing different parsings on
QbeastColumnStatsTestBuilder
.