Investigate usage of pynvml -> rocml delegation object #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows to use `import pynvml` in the rest of the code.
Implements `nvmlInit` etc. as `def nvmlInit(self): ...` etc. Since we register an object `Pynvml()` for pynvml in order to make the pyrsmi routines available via `__getattr__`, `pynvml.nvmlInit()` etc. gets resolved to `pynvml.nvmlInit(self)` etc.
domcharrier
force-pushed
the
rocm-dev-patch-domcharrier-1
branch
from
e1d8e3f to
20bba27
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pynvmlmodule into thesys.modulesmodule registry.import pynvmlin the rest of the code.Discussion
pynvml -> rocmlfunctionality move into thepyrsmiproject?pynnml-using packages might use different APIs and thus might want to register differingpynvml->rocmldelegation modules. One registration could break another package.