Adds gamepad exit hotkeys (plus and minus) to the input section #504
+323
−23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s the settings were reset to default
…hen changing parameters
GreemDev
requested changes
Jan 8, 2025
| private static bool hotButtonMinus = false; | ||
| private static bool HotExit = false; | ||
|
|
||
| public bool spetialExit() |
| bool ignoreControllerApplet) | ||
| : base(inputManager, glLogLevel, aspectRatio, enableMouse, hideCursorMode, ignoreControllerApplet) { } | ||
| bool ignoreControllerApplet, | ||
| int SpetialExitEmulator) |
| bool ignoreControllerApplet) | ||
| : base(inputManager, glLogLevel, aspectRatio, enableMouse, hideCursorMode, ignoreControllerApplet) | ||
| bool ignoreControllerApplet, | ||
| int SpetialExitEmulator) |
src/Ryujinx/Headless/Options.cs
Outdated
| @@ -274,6 +277,9 @@ private static string OptionName(string propertyName) => | |||
| [Option("enable-mouse", Required = false, Default = false, HelpText = "Enable or disable mouse support.")] | |||
| public bool EnableMouse { get; set; } | |||
|
|
|||
| [Option("enable-press-hotkeys-to-exit", Required = false, Default = 0, HelpText = "press the minus and plus buttons to: 0 -disable, 1 - exit app, 2 - exit game.")] | |||
| public int spetialExit { get; set; } | |||
There was a problem hiding this comment.
Property name casing + misspelling
| bool ignoreControllerApplet) | ||
| : base(inputManager, glLogLevel, aspectRatio, enableMouse, hideCursorMode, ignoreControllerApplet) | ||
| bool ignoreControllerApplet, | ||
| int SpetialExitEmulator) |
src/Ryujinx/Headless/WindowBase.cs
Outdated
| @@ -88,6 +88,7 @@ public static void QueueMainThreadAction(Action action) | |||
|
|
|||
| private readonly AspectRatio _aspectRatio; | |||
| private readonly bool _enableMouse; | |||
| private readonly int _SpetialExitEmulator; | |||
| }), | ||
| (60, static cff => | ||
| { | ||
| cff.SpetialExitEmulator = 1; |
There was a problem hiding this comment.
New features should generally be disabled by default; the user may not want the functionality
There was a problem hiding this comment.
Sorry, I fixed everything
|
Download the artifacts for this pull request: |
…xed initialization of the new function, defaults to 0
…essing a hotkey (unnecessary check removed)
GreemDev
requested changes
Jan 11, 2025
| /// <summary> | ||
| /// Allows you to choose from three options: do nothing, exit the application, exit the emulator | ||
| /// </summary> | ||
| public int specialExitEmulator { get; set; } |
There was a problem hiding this comment.
Please, when adding new properties, follow the style of the items you are adding.
SpecialExitEmulator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds gamepad exit hotkeys (plus and minus) to the input section. Pressing them simultaneously will trigger one of two events: exit the application or exit the game. This can be disabled. Only works for gamepads