Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused fields from job schema #1307

Merged
merged 1 commit into from
Jul 8, 2024
Merged

Remove unused fields from job schema #1307

merged 1 commit into from
Jul 8, 2024

Conversation

despadam
Copy link

@despadam despadam commented Jul 3, 2024

Description

The current job.schema contains:

  • A property messageSent which is never used. The details/content about the messages sent (RabbitMQ messages, emails, etc.) should be provided via the configuration file.
  • Properties datasetValidation and datasetsValidation. We should only use the second one (datasetsValidation).

Motivation

Fix #621

Changes:

  • Removing the unused properties from job.schema.
  • Fix casl-ability to use only datasetsValidation.

@despadam despadam requested a review from sofyalaski July 3, 2024 09:34
@despadam despadam self-assigned this Jul 3, 2024
@despadam despadam merged commit dd95986 into release-jobs Jul 8, 2024
1 check passed
@despadam despadam deleted the 621-jobs-migration-schema branch July 8, 2024 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sofyalaski sofyalaski sofyalaski approved these changes

Assignees

@despadam despadam

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@despadam @sofyalaski