feat(metrics): add metrics logging and configuration support #1559
+144
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Junjiequan
changed the title
4 tasks
Junjiequan
changed the title
Junjiequan
force-pushed
the
SWAP-4345-scicat-be-metrics-system-poc
branch
from
72084b7 to
a8911c0
Compare
Junjiequan
force-pushed
the
SWAP-4345-scicat-be-metrics-system-poc
branch
from
a1f424b to
f656e3a
Compare
Junjiequan
changed the title
nitrosx
reviewed
Jan 8, 2025
Comment on lines
+48
to
+49
| (env: NodeJS.ProcessEnv) => env.METRICS_ENABLED === "yes", | ||
| ), |
There was a problem hiding this comment.
Can we use the configuration module that is imported on line 43?
There was a problem hiding this comment.
I have checked official documentation and some other articles. ConditionalModule.registerWhen method do not support access to the configService.
The cleanest way is to use ConditionalModule.registerWhen and fetch env directly, however, there's hack to achieve same result with DyncmiModule with increased complexity.
Junjiequan
force-pushed
the
SWAP-4345-scicat-be-metrics-system-poc
branch
from
32c4913 to
92098f3
Compare
Junjiequan
force-pushed
the
SWAP-4345-scicat-be-metrics-system-poc
branch
from
92098f3 to
a99a96d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Motivation
Fixes
Changes:
Tests included
Documentation
official documentation info