Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 6-1-2025 #1599

Merged
merged 17 commits into from
Jan 7, 2025
Merged

Release 6-1-2025 #1599

merged 17 commits into from
Jan 7, 2025

Conversation

Junjiequan
Copy link
Contributor

@Junjiequan Junjiequan commented Jan 6, 2025

Description

Motivation

Fixes

  • Bug fixed (#X)

Changes:

  • changes made

Tests included

  • Included for each change/fix?
  • Passing?

Documentation

  • swagger documentation updated (required for API changes)
  • official documentation updated

official documentation info

@Junjiequan Junjiequan requested a review from nitrosx January 6, 2025 14:39
dependabot bot and others added 16 commits January 6, 2025 15:45
Bumps [@typescript-eslint/parser](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/parser) from 8.18.2 to 8.19.0.
- [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases)
- [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/parser/CHANGELOG.md)
- [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v8.19.0/packages/parser)

---
updated-dependencies:
- dependency-name: "@typescript-eslint/parser"
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
…ypescript-eslint/parser-8.19.0

build(deps-dev): bump @typescript-eslint/parser from 8.18.2 to 8.19.0
Bumps [concurrently](https://github.com/open-cli-tools/concurrently) from 9.1.1 to 9.1.2.
- [Release notes](https://github.com/open-cli-tools/concurrently/releases)
- [Commits](open-cli-tools/concurrently@v9.1.1...v9.1.2)

---
updated-dependencies:
- dependency-name: concurrently
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
…oncurrently-9.1.2

build(deps-dev): bump concurrently from 9.1.1 to 9.1.2
Bumps [@types/lodash](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/lodash) from 4.17.13 to 4.17.14.
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases)
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/lodash)

---
updated-dependencies:
- dependency-name: "@types/lodash"
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
…ypes/lodash-4.17.14

build(deps-dev): bump @types/lodash from 4.17.13 to 4.17.14
Bumps [uuid](https://github.com/uuidjs/uuid) from 11.0.3 to 11.0.4.
- [Release notes](https://github.com/uuidjs/uuid/releases)
- [Changelog](https://github.com/uuidjs/uuid/blob/main/CHANGELOG.md)
- [Commits](uuidjs/uuid@v11.0.3...v11.0.4)

---
updated-dependencies:
- dependency-name: uuid
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
…uid-11.0.4

build(deps): bump uuid from 11.0.3 to 11.0.4
Bumps [@typescript-eslint/eslint-plugin](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/eslint-plugin) from 8.18.2 to 8.19.0.
- [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases)
- [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/eslint-plugin/CHANGELOG.md)
- [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v8.19.0/packages/eslint-plugin)

---
updated-dependencies:
- dependency-name: "@typescript-eslint/eslint-plugin"
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
…ypescript-eslint/eslint-plugin-8.19.0

build(deps-dev): bump @typescript-eslint/eslint-plugin from 8.18.2 to 8.19.0
Bumps [@casl/ability](https://github.com/stalniy/casl/tree/HEAD/packages/casl-ability) from 6.7.2 to 6.7.3.
- [Release notes](https://github.com/stalniy/casl/releases)
- [Changelog](https://github.com/stalniy/casl/blob/master/packages/casl-ability/CHANGELOG.md)
- [Commits](https://github.com/stalniy/casl/commits/@casl/ability@6.7.3/packages/casl-ability)

---
updated-dependencies:
- dependency-name: "@casl/ability"
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
…asl/ability-6.7.3

build(deps): bump @casl/ability from 6.7.2 to 6.7.3
Bumps [@types/node](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/node) from 22.10.2 to 22.10.5.
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases)
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/node)

---
updated-dependencies:
- dependency-name: "@types/node"
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
…ypes/node-22.10.5

build(deps-dev): bump @types/node from 22.10.2 to 22.10.5
Bumps [mongoose](https://github.com/Automattic/mongoose) from 8.9.2 to 8.9.3.
- [Release notes](https://github.com/Automattic/mongoose/releases)
- [Changelog](https://github.com/Automattic/mongoose/blob/master/CHANGELOG.md)
- [Commits](Automattic/mongoose@8.9.2...8.9.3)

---
updated-dependencies:
- dependency-name: mongoose
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
…ongoose-8.9.3

build(deps): bump mongoose from 8.9.2 to 8.9.3
Copy link
Contributor

@sbliven sbliven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Junjiequan Can you add more detail to these release PRs? I feel like they should include a draft of the release notes.

Since this release seems only CI changes for the SDK generator it looks ok.

@@ -7,7 +7,7 @@ on:

env:
NODE_VERSION: 20.x
SDK_VERSION: latest
SDK_VERSION: 0.0.1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this need to be updated regularly in the future? If so that should be documented in the README.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be a one-time fix and will be used only for local development. The change is intended to address the issue with the Python SDK where pip install does not recognize tags labeled as “latest” and requires a numeric version instead.

@Junjiequan
Copy link
Contributor Author

@Junjiequan Can you add more detail to these release PRs? I feel like they should include a draft of the release notes.

Since this release seems only CI changes for the SDK generator it looks ok.

@sbliven @nitrosx
I agree that we should have a release description for breaking changes. For minor and patch updates though, I believe auto generated changelog should suffice, if not we should try to make them suffice by setting rules.
The intention of creating release PR was not to collect and summarize a draft for all the changes, it was to automize the release process and easier roll-back. I do think there's room for automation process improvement and would be happy to hear suggetions

@Junjiequan Junjiequan merged commit 11783c5 into release Jan 7, 2025
1 check passed
@sbliven
Copy link
Contributor

sbliven commented Jan 7, 2025

@Junjiequan Is is possible to see the auto-generated changelog before merging? If so maybe we could have a PR template for releases that would link this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants