Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor fix and better naming for variables #1612

Merged
merged 3 commits into from
Jan 10, 2025

Conversation

sofyalaski
Copy link
Contributor

Description

Minor changes in variable names to improve documentation

Motivation

While creating documentation some variables created confusion.

Fixes

  • Bug fixed (#X)

Changes:

  • tests 1750-1860 response for successful calls changed to SuccessfulGetStatusCode instead of Patch
  • lines 20-93 renamed variables to better represent their meaning. Based on job type and ownership info.
  • newDataset renamed to newJob in each test

Tests included

  • Included for each change/fix?
  • Passing?

Documentation

  • swagger documentation updated (required for API changes)
  • official documentation updated

official documentation info

* tests 1750-1860 response for successful calls changed to SuccessfulGetStatusCode instead of Patch
* lines 20-93 renamed variables to better represent their meaning. Based on job type and ownership info.
* newDataset renamed to newJob in each test
@sofyalaski sofyalaski requested a review from despadam January 10, 2025 12:58
@despadam despadam merged commit 8dba6df into SciCatProject:release-jobs Jan 10, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants