Replace psalm to phpstan and fix some linter errors

README.md

@@ -8,9 +8,6 @@
     <a href="https://packagist.org/packages/serafim/ffi-sdl"><img src="https://poser.pugx.org/serafim/ffi-sdl/downloads?style=for-the-badge" alt="Total Downloads"></a>
     <a href="https://raw.githubusercontent.com/serafim/ffi-sdl/master/LICENSE.md"><img src="https://poser.pugx.org/serafim/ffi-sdl/license?style=for-the-badge" alt="License MIT"></a>
 </p>
-<p align="center">
-    <a href="https://github.com/SerafimArts/ffi-sdl/actions"><img src="https://github.com/SerafimArts/ffi-sdl/workflows/build/badge.svg"></a>
-</p>
 
 A SDL FFI bindings for the PHP language.
 

phpstan.neon

@@ -30,3 +30,6 @@ parameters:
     inferPrivatePropertyTypeFromConstructor: true
     tipsOfTheDay: false
     checkMissingCallableSignature: true
+    ignoreErrors:
+        - '#^PHPDoc tag @var with type FFI\|object#'
+        - '#^Call to an undefined method FFI\|object#'

src/Audio/Format.php

@@ -4,6 +4,7 @@
 
 namespace Serafim\SDL\Audio;
 
+// @phpstan-ignore-next-line offsetAccess.nonOffsetAccessible
 if (\unpack('S', "\x01\x00")[1] === 1) {
     define('Serafim\SDL\Audio\AUDIO_U16SYS', 0x0010);
     define('Serafim\SDL\Audio\AUDIO_S16SYS', 0x8010);

src/SDL.php

@@ -141,7 +141,7 @@ public function __construct(
         parent::__construct(\FFI::cdef((string) $header, $this->library));
     }
 
-    private function getHeader(PreprocessorInterface $pre, ?CacheInterface $cache): string|\Stringable
+    private function getHeader(PreprocessorInterface $pre, ?CacheInterface $cache): \Stringable
     {
         if ($cache !== null) {
             return new CacheAwareHeader($this->platform, $this->version, $pre, $cache);
@@ -151,17 +151,20 @@ private function getHeader(PreprocessorInterface $pre, ?CacheInterface $cache):
     }
 
     /**
+     * @param non-empty-string|null $library
      * @return non-empty-string
-     *
-     * @psalm-suppress MoreSpecificReturnType
-     * @psalm-suppress LessSpecificReturnStatement
      */
     private function detectLibraryPathname(?string $library): string
     {
         if ($library !== null) {
-            return \realpath($library) ?: Locator::resolve($library) ?? $library;
+            /**
+             * @var non-empty-string
+             * @phpstan-ignore-next-line ternary.shortNotAllowed
+             */
+            return \realpath($library) ?: Locator::resolve($library) ?: $library;
         }
 
+        /** @var non-empty-string */
         return match ($this->platform) {
             Platform::WINDOWS => Locator::resolve('SDL2.dll')
                 ?? throw new \RuntimeException(<<<'error'
@@ -178,13 +181,15 @@ private function detectLibraryPathname(?string $library): string
                     Please make sure the SDL2 library is installed or specify
                     the path to the binary explicitly.
                     error),
+            // @phpstan-ignore-next-line match.alwaysTrue
             Platform::DARWIN => Locator::resolve('libSDL2-2.0.0.dylib')
                 ?? throw new \RuntimeException(<<<'error'
                     Could not load [libSDL2-2.0.0.dylib].
 
                     Please make sure the SDL2 library is installed or specify
                     the path to the binary explicitly.
                     error),
+            default => throw new \RuntimeException('Unknown platform'),
         };
     }
 
@@ -194,7 +199,7 @@ private function detectLibraryPathname(?string $library): string
     private function detectVersion(): VersionInterface
     {
         /**
-         * @var object{SDL_GetVersion:callable(object):void} $ffi
+         * @var object{SDL_GetVersion:callable(object):void}|\FFI $ffi
          */
         $ffi = \FFI::cdef(<<<'CLANG'
             typedef uint8_t Uint8;