Add optional names for colocation groups #665
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rgrandl
force-pushed
the
add_optional_names_for_coloc_groups
branch
2 times, most recently
from
db5a481 to
8480bb8
Compare
We've discussed to enable the user to specify group names. Right now we compute automatically the group names as the name of the first component in each group. This PR enables the user to specify group names (optionally). This is becoming more and more important given that we allow the user to configure various knobs in the deployer, and many knobs make sense for a particular colocation group. E.g., secrets/config maps make sense for colocation group. Maybe we will allow people to configure resource requirements per colocation group at some point, etc.
rgrandl
force-pushed
the
add_optional_names_for_coloc_groups
branch
from
8480bb8 to
be31909
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've discussed in the past to enable the user to specify group names. Right now we compute automatically the group names as the name of the first component in each group.
This PR enables the user to specify group names (optionally). This is becoming more and more important given that we allow the user to configure various knobs in the deployer, and many knobs make sense for a particular colocation group. E.g., secrets/config maps make sense for colocation group. Maybe we will allow people to configure resource requirements per colocation group at some point, etc.