Colocation groups config #667
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rgrandl
force-pushed
the
colocation_options_discussion
branch
3 times, most recently
from
4e10205 to
9f913d1
Compare
Right now we specify the components that should run together in a colocation group. For all the others we run them in their own groups. However, given that the group is the unit of deployment, we'll have to add configuration knobs that make sense per colocation group. This PR provides some options to set per colocation group knobs in the config.
rgrandl
force-pushed
the
colocation_options_discussion
branch
from
9f913d1 to
17a44b6
Compare
|
We never reached a conclusion on what is the right way to specify collocation groups. The way we let users specify collocation groups as of now seems fine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now we specify the components that should run together in a colocation group. For all the others we run them in their own groups. However, given that the group is the unit of deployment, we'll have to add configuration knobs that make sense per colocation group.
This PR provides some options to set per colocation group knobs in the config.