Add Market promotion boosted tag #280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
randy75828
approved these changes
Dec 4, 2024
scripts/check_configs.ts
Outdated
| const hasInvalidMarketPromoIds = checkValidEntries(marketPromoIds, marketIds) | ||
| const hasDuplicateMarketPromoIds = checkDuplicateEntries(marketPromoIds) | ||
|
|
||
| // check for valid market id |
There was a problem hiding this comment.
can u remove all the comments? not adding much value because the code is quite self explanatory already
thanhpn
force-pushed
the
feat/market-promo
branch
from
39a84b1 to
9694261
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.