Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ajout d'une option pour étendre les lignes de la table et présenter les données optionnelles d'une chanson #72

Merged
merged 5 commits into from
Dec 5, 2024

Conversation

hvdbm
Copy link
Member

@hvdbm hvdbm commented Dec 4, 2024

Description

🚀 Nouveauté

  • Il est désormais possible de cliquer sur les lignes de la table listant les chansons pour présenter les données supplémentaires (année de sortie, album, etc...) en étendant la ligne.
Capture d’écran, le 2024-12-03 à 20 58 13

🎉 Quality of life

  • Retrait de la colonne plateform dans les colonnes possibles de la table.

Checklist

À être vérifié par les reviewers:

  • La PR a un bon titre
  • Les labels sont bien attribués
  • Les champs de la PR sont correctement remplis

@hvdbm hvdbm added the enhancement New feature or request label Dec 4, 2024
@hvdbm hvdbm requested review from Ithyx and rakruk December 4, 2024 02:03
Copy link

cloudflare-workers-and-pages bot commented Dec 4, 2024

Deploying mellotron with  Cloudflare Pages  Cloudflare Pages

Latest commit: b51cb04
Status: ✅  Deploy successful!
Preview URL: https://a1738ab6.mellotron.pages.dev
Branch Preview URL: https://feat-song-parameters.mellotron.pages.dev

View logs

Copy link
Member

@rakruk rakruk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bonne fonctionnalité!

@hvdbm hvdbm requested a review from rakruk December 4, 2024 22:32
Copy link
Member

@rakruk rakruk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@hvdbm hvdbm merged commit 10de3e7 into main Dec 5, 2024
2 checks passed
@hvdbm hvdbm deleted the feat/song-parameters branch December 5, 2024 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants