Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MAM-2930-make-a-new-endpoint-for-a-list-of-grouped-onboarding-accounts #202

Merged
merged 12 commits into from
Nov 3, 2023
Merged

MAM-2930-make-a-new-endpoint-for-a-list-of-grouped-onboarding-accounts #202

merged 12 commits into from
Nov 3, 2023

Conversation

jtomchak
Copy link
Contributor

@jtomchak jtomchak commented Nov 2, 2023 •
edited
Loading

  • Additional endpoint /api/v2/onboarding_follow_recommendations/accounts that will return only recommended accounts as an array. no hashtags or meta data

Try it out: https://staging.moth.social//api/v2/onboarding_follow_recommendations/accounts

Resolves MAM-2930

@jtomchak jtomchak self-assigned this Nov 2, 2023
@jtomchak jtomchak marked this pull request as ready for review November 2, 2023 19:14
@jtomchak jtomchak requested a review from rileyhCode November 2, 2023 19:14
rileyhCode
rileyhCode requested changes Nov 3, 2023
View reviewed changes
Copy link

@rileyhCode rileyhCode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small change wrt @PXL

app/lib/onboarding/v2/onboarding_categories_development.yml Show resolved Hide resolved
rileyhCode
rileyhCode approved these changes Nov 3, 2023
View reviewed changes
Copy link

@rileyhCode rileyhCode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved then.

@jtomchak jtomchak merged commit 85400a4 into main Nov 3, 2023
23 checks passed
@jtomchak jtomchak deleted the MAM-2930-make-a-new-endpoint-for-a-list-of-grouped-onboarding-accounts branch November 3, 2023 01:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rileyhCode rileyhCode rileyhCode approved these changes

Assignees

@jtomchak jtomchak

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jtomchak @rileyhCode