Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add option to select calendars #257

Draft
wants to merge 64 commits into
base: dev
Choose a base branch
from
Draft

Add option to select calendars #257

wants to merge 64 commits into from
+175 −79

Conversation

theboringhumane
Copy link
Member

No description provided.

theboringhumane and others added 30 commits December 22, 2024 11:51
@theboringhumane
Updated guidelines
5d4c668
@overflow-sudo @theboringhumane
Placeholder provided by media player
d5ed329 
If the artwork data cannot be found, it will be replaced with a placeholder provided by media player
@Alexander5015 @theboringhumane
rewrite logic for detirmining when to change album art and when to us…
8b71656 
…e app icon as a placeholder
@Alexander5015 @theboringhumane
Hide mini app icon when app icon is being used for artwork
1772888
@Alexander5015 @theboringhumane
Use the isPlaying function rather than guessing based on playback rat…
3a47e98 
…e is this is sometimes 0 even though something is playing
@Alexander5015 @theboringhumane
adjust states inside thread for new playing detection
4c8f6ec
@Alexander5015 @theboringhumane
Update bundle identifier logic for more accurate icon
dcf7810
@Alexander5015 @theboringhumane
allow timeline to update while paused, for the case when the back ski…
e4d75cb 
…p button is pressed or the source modifies the elapsedTime after being paused
@Alexander5015 @theboringhumane
More fixes
e4e4e12
@Alexander5015 @theboringhumane
modify screen lock monitoring
6c8cd9e
@Alexander5015 @theboringhumane
Changed selectedScreen to preferredScreen and added a seperate select…
5bd2e58 
…edDisplay so that boringNotch remembers the last manually selected screen and tries to use it if it is available
@Alexander5015 @theboringhumane
Add a Default Key and settings for show on all displays
8eb71f7
@Alexander5015 @theboringhumane
Add all displays as a beta feature
53a0bcc
@Alexander5015 @theboringhumane
Dynamically change settings views based on preferences and fix deprec…
9d0ff84 
…ated onChange calls
@Alexander5015 @theboringhumane
Refactor the code by transferring certain elements from BoringViewMod…
1f6414c 
…el to BoringView Coordinator. This will help isolate the singleton-required code from the ViewModel that is now specific to each window.
@Alexander5015 @theboringhumane
Use new BoringView Coordinator, refactor matters.swift and sizes, and…
6699e80 
… add new show on all displays beta option
@Alexander5015 @theboringhumane
Move BoringViewCoordinator into folder
b209365
@Alexander5015 @theboringhumane
Add the option to customize the size of the notch window on notched s…
d023e7c 
…creens (seperate control from non-notched displays)
@Alexander5015 @theboringhumane
add opactity and blur to NotchHomeView
da31a97
@AdrianGri @theboringhumane
Add option to select calendars
3be167a
@AdrianGri @theboringhumane
Put extensionManager back to a state object
1c89f76
@overflow-sudo @theboringhumane
Placeholder provided by media player
f28a417 
If the artwork data cannot be found, it will be replaced with a placeholder provided by media player
@Alexander5015 @theboringhumane
rewrite logic for detirmining when to change album art and when to us…
505b235 
…e app icon as a placeholder
@Alexander5015 @theboringhumane
Hide mini app icon when app icon is being used for artwork
fc2972a
@Alexander5015 @theboringhumane
Use the isPlaying function rather than guessing based on playback rat…
8914aa0 
…e is this is sometimes 0 even though something is playing
@Alexander5015 @theboringhumane
adjust states inside thread for new playing detection
1a1bf88
@Alexander5015 @theboringhumane
Update bundle identifier logic for more accurate icon
9b61d78
@Alexander5015 @theboringhumane
allow timeline to update while paused, for the case when the back ski…
f71984c 
…p button is pressed or the source modifies the elapsedTime after being paused
@Alexander5015 @theboringhumane
More fixes
a9ce95c
@Alexander5015 @theboringhumane
modify screen lock monitoring
a527654
Alexander5015 and others added 10 commits December 22, 2024 11:54
@Alexander5015 @theboringhumane
Add a Default Key and settings for show on all displays
9497fac
@Alexander5015 @theboringhumane
Add all displays as a beta feature
bc8e09b
@Alexander5015 @theboringhumane
Dynamically change settings views based on preferences and fix deprec…
8a9063d 
…ated onChange calls
@Alexander5015 @theboringhumane
update timeline slider logic for better behaviour when paused
2a96224
@Alexander5015 @theboringhumane
Refactor the code by transferring certain elements from BoringViewMod…
652e0c9 
…el to BoringView Coordinator. This will help isolate the singleton-required code from the ViewModel that is now specific to each window.
@Alexander5015 @theboringhumane
Use new BoringView Coordinator, refactor matters.swift and sizes, and…
4cb56fe 
… add new show on all displays beta option
@Alexander5015 @theboringhumane
Move BoringViewCoordinator into folder
cb98366
@Alexander5015 @theboringhumane
Add the option to customize the size of the notch window on notched s…
a28cecc 
…creens (seperate control from non-notched displays)
@AdrianGri @theboringhumane
Add option to select calendars
3de9509
@AdrianGri @theboringhumane
Put extensionManager back to a state object
7b33acb
@cori-ai cori-ai bot added the cori-ai-review Cori AI review label Dec 22, 2024
@cori-ai cori-ai
Copy link

cori-ai bot commented Dec 22, 2024

Hey @theboringhumane! 👋

Just wrapped up reviewing your code! Here's what I found:

  • No comments were provided during the code review.
  • The code changes were reviewed and found to be satisfactory.
  • No issues or suggestions for improvement were identified.
  • The code adheres to the project's coding standards and best practices.
  • The implementation is clear and well-documented.

Feel free to ping me if anything's not clear or if you want to chat about any of the suggestions! I'm here to help you ship awesome code! 🚀

Cheers! 🦦
~ CoriAI ✨

@cori-ai cori-ai bot added the cori-ai-review-complete Cori AI review complete label Dec 22, 2024
@theboringhumane
Copy link
Member Author

cc @richardkunkli

@cori-ai cori-ai
Copy link

cori-ai bot commented Dec 22, 2024

Hey @theboringhumane! 👋

Just wrapped up reviewing your code! Here's what I found:

  • No comments were provided during the code review.
  • The code changes were reviewed and found to be satisfactory.
  • No issues or suggestions for improvement were identified.
  • The code adheres to the project's coding standards and best practices.
  • The implementation is clear and well-documented.

Feel free to ping me if anything's not clear or if you want to chat about any of the suggestions! I'm here to help you ship awesome code! 🚀

Cheers! 🦦
~ CoriAI ✨

@cori-ai cori-ai
Copy link

cori-ai bot commented Jan 3, 2025

Hey @theboringhumane! 👋

Just wrapped up reviewing your code! Here's what I found:

  • No comments were provided during the code review.
  • The code changes were reviewed and found to be satisfactory.
  • No issues or suggestions for improvement were identified.
  • The code adheres to the project's coding standards and best practices.
  • The implementation is clear and well-documented.

Feel free to ping me if anything's not clear or if you want to chat about any of the suggestions! I'm here to help you ship awesome code! 🚀

Cheers! 🦦
~ CoriAI ✨

This was linked to issues Jan 14, 2025
[BUG] Airdrop broken and adds watermark #286
Open
[BUG]File renaming in dropzone #264
Open
[BUG] Media art gradient reveals notch. #230
Open
[BUG] RAM used was over 3 GB #225
Open
[BUG] Sneak peek on song change. #211
Open
[BUG] Some issue with airdrop #155
Open
(Issue) Boring notch covering text from menubar #121
Open
@cori-ai cori-ai
Copy link

cori-ai bot commented Jan 14, 2025

Hey @theboringhumane! 👋

Just wrapped up reviewing your code! Here's what I found:

  • No comments were provided during the code review.
  • The code changes were reviewed and found to be satisfactory.
  • No issues or suggestions for improvement were identified.
  • The code adheres to the project's coding standards and best practices.
  • The implementation is clear and well-documented.

Feel free to ping me if anything's not clear or if you want to chat about any of the suggestions! I'm here to help you ship awesome code! 🚀

Cheers! 🦦
~ CoriAI ✨

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cori-ai-review Cori AI review cori-ai-review-complete Cori AI review complete
Projects
None yet
Milestone
No milestone
5 participants
@theboringhumane @Alexander5015 @overflow-sudo @AdrianGri @andreamoretti890