Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Purely to new Azure.Data clients, #11

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

petero-dk
Copy link

Cleaned the code for unused references, and nuget package requirements.

Removed deprecated Storage packages.

Support Managed Identities

BREAKING CHANGE IN THIS CODE:
Does not support deleting expired blobs (should really be managed by the blob lifecycle setup instead of this code)

@petero-dk
Copy link
Author

Obviously this is not complete, but a sample of an implementation for now

@TheByteStuff
Copy link
Owner

Thanks for the submission. For me this is a fairly big task relative to the bandwidth I have - I haven't even delved into .NET 8. Will need to get that upgraded before trying to run your samples. Will look deeper as soon as I can.

Thank you!

@petero-dk
Copy link
Author

.NET 8 is not really a requirement for this to run, it was just a simple change of the framework used (the ones specified in this project are out of support and I could not be bothered to install them, they are only used for the console and the test project)

I will be working on this some more over the next couple of weeks, I will try to maintain backwards compatibility but will implement functions that allow me to

Upload files with static file names in dynamically named (date) folders

Restore all tables at once

Utilize blob storage lifecycle management for blob expiration (hot -> cold -> gone)

Also I am going to include the CLI into the solution but still allow the Nuget to be published with the api.

@TheByteStuff
Copy link
Owner

Good to know on the .Net8. I try to use the lowest version possible just to keep the package available to the most users. I was hoping to pull your changes in and do a quick run to see how it worked and position it for at least a pre-release path. I'm planning to make it a V7. If you want to, go ahead and update the package information to reflect a V7 pre. Once I get a chance to get the .Net8 running I'll experiment with lower versions.

CLI option as a reference is cool. I have a CLI package elsewhere here that I publish not only as a reference implementation but also to put out for DotNet Tool. There may be a way to do that all under one project. I just never delved into it. I'm not a developer day to day any more and my Visual Studio/.Net skills were functional but not stellar.

I appreciate your continued time and effort!

@TheByteStuff
Copy link
Owner

I just created a 7.0.0-pre branch and hopefully properly pulled in the changes from your pull requests to it. I did change the version to 7.0.0-pre in the package info as well. If I missed something please let me know. If you can make future pull requests to the 7.0.0-pre then when ready I can create a pre-release lib for NuGet. I'll keep master for 6x version for now in case changes are needed for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants