feat: add sd-jwt issuer support and e2e test #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Timo Glastra <timo@animo.id>
feat: add sd-jwt support
Update README.md for code discrepancies
Signed-off-by: Timo Glastra <timo@animo.id>
Signed-off-by: Timo Glastra <timo@animo.id>
Signed-off-by: Timo Glastra <timo@animo.id>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR builds on top of Sphereon-Opensource#78, and adds support for issuance side for sd-jwt vcs as well as adds an e2e test using sd-jwt vcs
It's not fully complete yet, as I need to define the
credentialinterface that is passed as input to the issueCredential. Sd JWT VCs have a different interface than the other credential types, and need to make sure the right data is passed.An alternative I was thinking of, is whether it may be possible to just pass in a signed credential, and not use the
signedCallbacketc..That way we can create a SD-JWT VC based on the request, and then pass it to issue credential directly (which will do the other validations)