Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for multipart upload (#160) #161

Merged
merged 1 commit into from
Jan 3, 2019
Merged

Add support for multipart upload (#160) #161

merged 1 commit into from
Jan 3, 2019

Conversation

richardkiene
Copy link
Contributor

storage/objects.go Show resolved Hide resolved
storage/objects.go Show resolved Hide resolved
storage/objects.go Show resolved Hide resolved
storage/objects.go Show resolved Hide resolved
storage/objects.go Show resolved Hide resolved
storage/objects.go Show resolved Hide resolved
storage/objects.go Outdated Show resolved Hide resolved
storage/objects.go Outdated Show resolved Hide resolved
storage/objects.go Outdated Show resolved Hide resolved
storage/objects.go Outdated Show resolved Hide resolved
storage/objects.go Outdated Show resolved Hide resolved
* Fixes #160, but omits listing multipart uploads
@richardkiene
Copy link
Contributor Author

@dekobon I created #162 , #163 , #164 to address your points.

@twhiteman I think I've addressed all of your concerns in my latest push.

The failing travis-ci check is unrelated to this commit (it's an images issue) and I've run the test suite on my machine without issue. Furthermore I've verified that the MPU example code works when run against this PR.

Let me know if you have any more changes or if I can merge this in.

@twhiteman
Copy link
Contributor

@richardkiene yep, from the go-lang point of view I think your code is good to go 👍

@richardkiene richardkiene merged commit 04c0ab1 into master Jan 3, 2019
@richardkiene richardkiene deleted the mpu branch January 3, 2019 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants