-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TRITON-2469 Update joyent links to TritonDataCenter #201
base: v1
Are you sure you want to change the base?
Changes from 8 commits
12207a6
f285080
1737e76
e614325
e3f07b4
b06f5ad
0a23439
6e822c9
fabb0bf
0e66026
8cc235e
7361aee
c04fd53
8a014f2
c53000f
ab56931
3bfff2c
8e371f9
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,6 @@ | ||
// | ||
// Copyright (c) 2018, Joyent, Inc. All rights reserved. | ||
// Copyright 2024 MNX Solutions, Inc. | ||
// | ||
// This Source Code Form is subject to the terms of the Mozilla Public | ||
// License, v. 2.0. If a copy of the MPL was not distributed with this | ||
|
@@ -13,7 +14,7 @@ import ( | |
"strings" | ||
"testing" | ||
|
||
auth "github.com/joyent/triton-go/authentication" | ||
auth "github.com/TritonDataCenter/triton-go/authentication" | ||
) | ||
|
||
const BadURL = "**ftp://man($$" | ||
|
@@ -85,11 +86,11 @@ gnfBQoS89m3aO035henSfRFKVJkHaEoasj8hB3pwl9FGZUJp1c2JxiKzONqZhyGa | |
} | ||
|
||
func TestNew(t *testing.T) { | ||
mantaURL := "https://us-east.manta.joyent.com" | ||
mantaURL := "https://us-central.manta.mnx.io" | ||
tsgEnv := "http://tsg.test.org" | ||
jpcTritonURL := "https://us-east-1.api.joyent.com" | ||
jpcTritonURL := "https://us-central-1.api.mnx.io" | ||
spcTritonURL := "https://us-east-1.api.samsungcloud.io" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Remove all SPC references entirely. This entire section should be reworked to not use any pre-defined URLs. It should only work with user supplied run-time defined account information. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. These are unit tests AFAICT. Would you like run-time defined account information for these? |
||
jpcServiceURL := "https://tsg.us-east-1.svc.joyent.zone" | ||
jpcServiceURL := "https://tsg.us-central-1.svc.triton.zone" | ||
spcServiceURL := "https://tsg.us-east-1.svc.samsungcloud.zone" | ||
privateInstallUrl := "https://myinstall.mycompany.com" | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove samsung and tritoncompute.cloud. Honestly, the whole "short hand dc reference" should be eliminated entirely.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This has been fixed. See comment below regarding removal of "short hand dc reference".