feat: throw error if useWallet is being used outside the WalletProvider #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This resolves the deprecated warning that started appearing in the console after upgrading to zustand@^4.3.8
This also renames the context provider to match the exported "WalletProvider", and the context object itself is imported via a `useWalletContext` hook.
drichar
changed the title
drichar
deleted the
txn-1560-show-error-if-usewallet-is-being-used-outside-the
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If the
useWallethook is being used outside of the React Context provider giving it access to the wallet clients, an error is thrown:This also renames the context provider to match the exported
WalletProvidermodule, and the context object itself is returned by theuseWalletContexthook.A warning has been appearing in the console that the default export of
zustand/shallowis deprecated, and will be removed in a future release. The named export is used now instead, which will stop the warning from appearing.Checklist