Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bump redocly/cli #178

Merged
merged 1 commit into from
Apr 18, 2024
Merged

fix: bump redocly/cli #178

merged 1 commit into from
Apr 18, 2024

Conversation

xespona
Copy link
Contributor

@xespona xespona commented Apr 18, 2024

we found out that ci-standard-checks and api-docs are using different versions of redocly/cli. This means that the openapi validation done through the standard checks does not match the one done by apidocs.

This is likely due to the fact that the configs used are different.

Changes

  1. modify the redocly config rules, adding two missing rules that api-docs has.
  2. remove --extends=minimal so it uses recommended which is what the redocly config has. (and apidocs)
  3. unpin the version from npx @redocly/cli@1.0.2 lint --extends=minimal "$f" so it uses the latest available (as apidocs does)

@xespona xespona force-pushed the NOJIRA-1234-bump-redocli branch from 420f96c to 336d855 Compare April 18, 2024 09:31
@xespona xespona merged commit 5bc3d40 into main Apr 18, 2024
7 checks passed
@xespona xespona deleted the NOJIRA-1234-bump-redocli branch April 18, 2024 09:52
@typeform-ops-gha
Copy link

🎉 This PR is included in version 1.29.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants