Feature/circular queue #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HardyYu
requested changes
May 27, 2024
There was a problem hiding this comment.
Good try! I listed some points that could cause this class to not work, please review and change them. Don't be afraid of changing someone else's code! Sometimes other people's code is faulted or no long apply to the current use case anymore. I also recommend to include your header in the Boardfiles/nucleol552zeq/Core/Src/main.cpp to check whether your code can pass compilation. The way how compiler works is that if you don't use it, then it won't be compiled. You can do some testing in the main to check whether or not your code is actually working.
HardyYu
requested changes
May 30, 2024
HardyYu
requested changes
May 30, 2024
HardyYu
reviewed
Jun 7, 2024
Yaremadzulynsky
approved these changes
Jun 12, 2024
Yaremadzulynsky
approved these changes
Jun 12, 2024
HardyYu
approved these changes
Jun 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What was completed, changed, or updated?
Implemented TM Cicular Queue
Why was this done (if applicable)?
to allow Tm to store MAVLINK message in queue waiting for use
Testing
What manual tests were used to validate the code?
What unit tests were used to validate the code?
Documentation
Milestone number and name:
Link to Asana task:
Link to Confluence documentation:
Reminders
Add reviewers to the PR
Mention the PR in the appropriate discord channel