Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add text outline and axis call to plot_maxmin_points #1237

Closed
wants to merge 5 commits into from

Conversation

MethaneRain
Copy link

@MethaneRain MethaneRain commented Nov 17, 2019

Description Of Changes

Create HiLo module with plot_maxmin_points function to replace local plot_maxmin_points function in old example notebook. Added axis call and added text outline with ability to alter line thickness and color of outline and added pressure text adjustment.

Note - pressure offset call needs to be adjusted better; on longitudes east and west of CONUS the pressure text becomes off-center of symbol

Create a High/Low plot_maxmin_points plot instance in example notebook.

Checklist

MethaneRain and others added 4 commits November 15, 2019 11:41
Made HiLo module for importing plot_maxmin_points function

Added ax call and text outline with format options
Removed local function of plot_maxmin_points

Used import of HILO module to get plot_maxmin_points
@CLAassistant
Copy link

CLAassistant commented Nov 17, 2019

CLA assistant check
All committers have signed the CLA.

@MethaneRain MethaneRain requested a review from dcamron as a code owner October 7, 2020 14:22
Base automatically changed from master to main February 22, 2021 22:39
@dopplershift dopplershift requested a review from a team as a code owner October 31, 2024 20:36
@dopplershift
Copy link
Member

Apologies for this languishing for so long. In the end, we implemented a more robust solution for peak finding in #3729, as well as exposed our scattertext() function directly for plotting. We do appreciate the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clean up High/Low Plotting Function A Bit
3 participants