Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make tests pass on macOS M2 #3256

Merged
merged 3 commits into from
Nov 1, 2023
Merged

Make tests pass on macOS M2 #3256

merged 3 commits into from
Nov 1, 2023

Conversation

dopplershift
Copy link
Member

Description Of Changes

This gets the suite passing on my M2. There are a couple contour tests that need a higher threshold for some reason, but manual inspection confirms tests are behaving as expected.

Need to fix a couple other tests.

@dopplershift
MNT: Update some image test thresholds
a83ba4a 
This gets the suite passing on my M2. There are a couple contour tests
that need a higher threshold for some reason, but manual inspection
confirms tests are behaving as expected.
@dopplershift dopplershift added Type: Maintenance Updates and clean ups (but not wrong) Area: Tests Affects tests hacktoberfest-accepted PRs accepted for contributions in hacktoberfest labels Oct 31, 2023
@dopplershift dopplershift added this to the October 2023 milestone Oct 31, 2023
@dopplershift dopplershift marked this pull request as ready for review October 31, 2023 22:35
@dopplershift dopplershift requested review from kgoebber and a team as code owners October 31, 2023 22:35
@dopplershift dopplershift requested review from dcamron and removed request for a team October 31, 2023 22:35
kgoebber
kgoebber previously approved these changes Nov 1, 2023
View reviewed changes
Copy link
Collaborator

@kgoebber kgoebber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@dopplershift dopplershift changed the title MNT: Update some image test thresholds Make tests pass on macOS M2 Nov 1, 2023
@dopplershift
Copy link
Member Author

I've got two more non-image tests failing locally.

@dopplershift
MNT: Mark test_moist_lapse_failure as xfail on mac arm64
f6773c2 
Apparently this problematic test fails here too.
dcamron
dcamron approved these changes Nov 1, 2023
View reviewed changes
Copy link
Member

@dcamron dcamron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passes locally on my M2 as well 👍

@dcamron dcamron merged commit 83308c3 into Unidata:main Nov 1, 2023
28 checks passed
@dopplershift dopplershift deleted the fix-apple-tests branch November 1, 2023 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcamron dcamron dcamron approved these changes

@kgoebber kgoebber kgoebber left review comments

Assignees
No one assigned
Labels
Area: Tests Affects tests hacktoberfest-accepted PRs accepted for contributions in hacktoberfest Type: Maintenance Updates and clean ups (but not wrong)
Projects
None yet
Milestone
December 2023
Development

Successfully merging this pull request may close these issues.
3 participants
@dopplershift @kgoebber @dcamron