Analytic Saturation Vapor Pressure #3726
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcamron
added
Type: Maintenance
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
dcamron
force-pushed
the
analytic-satvap
branch
from
a7c62db to
d1334f5
Compare
dcamron
force-pushed
the
analytic-satvap
branch
3 times, most recently
from
1a9b663 to
2e3383f
Compare
dcamron
force-pushed
the
analytic-satvap
branch
2 times, most recently
from
4ff23a1 to
6b436fe
Compare
|
I think it makes sense to do this by itself. I don't understand why the test is failing with overflow in EDIT: It's definitely overflowing, and we can just ignore in the test like we do on some others. In a notebook, it appears once and is then suppressed. |
dcamron
force-pushed
the
analytic-satvap
branch
from
6b436fe to
6243bfe
Compare
Comment on lines
+1564
to
+1573
| latent_heat = water_latent_heat_vaporization._nounit(temperature) | ||
| heat_power = (mpconsts.nounit.Cp_l - mpconsts.nounit.Cp_v) / mpconsts.nounit.Rv | ||
| exp_term = ((mpconsts.nounit.Lv / mpconsts.nounit.T0 - latent_heat / temperature) | ||
| / mpconsts.nounit.Rv) | ||
|
|
||
| return ( | ||
| mpconsts.nounit.sat_pressure_0c | ||
| * (mpconsts.nounit.T0 / temperature) ** heat_power | ||
| * np.exp(exp_term) | ||
| ) |
There was a problem hiding this comment.
This looks like it matches the paper and I don't see any better ways to approach the array math, so I'd say we're good to go here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dependent on #3725.
In a Christmas Eve sprint, I implemented the analytic saturation vapor pressure from Ambaum 2020, per recommendations from #626. Lots of updated test values, and these may change further, but I wanted to get the changes out there quickly so we could evaluate their impacts, as well as get the changes into the full test matrix.
All departures are small in relative magnitude, but some callouts for potential scrutiny:
test_sensitive_soundingtest_lfc_mltest_eland its extensionstest_dewpoint_specific_humidity_xarray(I reduced the precision instead of redefining the test data)test_equivalent_potential_temperature_maskedworked before. The calculations work on the individual masked array elements but for some reason it blows up on the full array.numpy.ma.expoffered no help. If anyone has any insight here it had me pulling my hair out a bit.I'm not touching image tests until the other PR goes in and we tackle a review here, and maybe not even until LCL.
I'll include an implementation and tests for the saturation vapor pressure over ice in this PR as well.
Happy holidays! 🎅